Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for thrift #1573

Open
dengliming opened this issue Nov 6, 2020 · 8 comments · May be fixed by #8370
Open

Add support for thrift #1573

dengliming opened this issue Nov 6, 2020 · 8 comments · May be fixed by #8370
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation

Comments

@dengliming
Copy link
Member

dengliming commented Nov 6, 2020

https://github.com/apache/thrift

Maybe can refer to the similar implementation by skywalking https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/thrift-plugin

@dengliming dengliming added the enhancement New feature or request label Nov 6, 2020
@iNikem
Copy link
Contributor

iNikem commented Nov 6, 2020

Can you elaborate what kind of support are you talking about? I am not very familiar with Thrift, but uses HTTP underneath, right? So our HTTP instrumentations already should take care of creating spans for remote calls. What else, do you think, would be useful here?

@iNikem iNikem added contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome release:after-ga labels Nov 6, 2020
@dengliming
Copy link
Member Author

It provide the similar features like gRPC.

@halfciga
Copy link

Can you elaborate what kind of support are you talking about? I am not very familiar with Thrift, but uses HTTP underneath, right? So our HTTP instrumentations already should take care of creating spans for remote calls. What else, do you think, would be useful here?

you can refer to this repository : https://github.com/opentracing-contrib/java-thrift

@ZRainc
Copy link

ZRainc commented Nov 9, 2022

When will Opentelemetry support Thrift?

@mateuszrzeszutek
Copy link
Member

Hey @ZRainc ,
The maintainers of this repo probably won't implement this (we don't have enough time/cycles to work on that), but we'll gladly accept a contribution.

@tkyun123 tkyun123 linked a pull request Apr 26, 2023 that will close this issue
@tkyun123
Copy link

I'm working on this,and will complete in next few weeks if it goes well

@ZRainc
Copy link

ZRainc commented Apr 27, 2023

I'm working on this,and will complete in next few weeks if it goes well

Sounds great,looking forward to your completion

@lancedeng
Copy link

I'm working on this,and will complete in next few weeks if it goes well

Great, any update on this topic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants