Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ignored HttpClientTest #2155

Open
iNikem opened this issue Feb 1, 2021 · 2 comments
Open

Review ignored HttpClientTest #2155

iNikem opened this issue Feb 1, 2021 · 2 comments
Labels
area:tests bug Something isn't working

Comments

@iNikem
Copy link
Contributor

iNikem commented Feb 1, 2021

A lot of subclasses of HttpClientTest ignore one or more tests. This leaves us blind to the actual problems with our instrumentations, where we don't support quite common cases, e.g. redirects. We should review and fix them all.

@jaydeluca
Copy link
Member

To add some context to this issue and to make sure I understand it - this is related to test classes that extend AbstractHttpClientTest and configure things like optionsBuilder.disableTestRedirects() which then causes a subset of tests to be ignored.

The ask is to update all the instrumentations that opt out of various tests so that they all properly instrument things like redirects, so that we can then remove these configurations.

Is that correct?

@trask
Copy link
Member

trask commented Dec 17, 2024

this is my understanding as well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants