Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all test failures on Windows #889

Open
trask opened this issue Aug 4, 2020 · 2 comments
Open

Fix all test failures on Windows #889

trask opened this issue Aug 4, 2020 · 2 comments
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome contributor experience Something that we can do to improve the experience of contributors (especially new contributors)

Comments

@trask
Copy link
Member

trask commented Aug 4, 2020

There are a few tests that fail on Windows (e.g. different socket related things). This is confusing for contributors who develop on Windows.
@trask trask added contributor experience Something that we can do to improve the experience of contributors (especially new contributors) release:required-for-ga labels Aug 4, 2020
@iNikem iNikem added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Oct 8, 2020
@trask
Copy link
Member Author

trask commented Apr 3, 2021

Ideally we would run github actions on both ubuntu-latest and windows-latest, but looks like we can't run linux docker containers on windows-latest (yet), which some of our tests require (actions/runner-images#1143)

@trask
Copy link
Member Author

trask commented Apr 6, 2021

a reasonable option here may be to have a github action on windows-latest that runs all the tests that don't use testcontainers

@trask trask mentioned this issue Jun 19, 2021
Merged
@trask trask removed the priority:p2 label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome contributor experience Something that we can do to improve the experience of contributors (especially new contributors)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trask @iNikem