automatic tracing of ws

[vmarchaud]

Is it applicable for Node or Browser or both
Node

Do you expect this plugin to be commonly used
Weekly Downloads: 10M (https://www.npmjs.com/package/ws)

What version of plugin are you interested in using
Versions: 5 - 7 (cover last 2 years of releases)

Additional context

• Is there a reference you could point for the well-defined lifecycle methods

I believe only elastic implemented an intrumentation for this module (https://github.com/elastic/apm-agent-nodejs/blob/master/lib/instrumentation/modules/ws.js)

[obecny]

Should we also support web socket on web too then ?

[dyladan]

Does websocket have a place to put the traceparent? afaik there is no way to add the tracing info without potentially modifying the user's payload?

[vmarchaud]

@obecny I believe we should at some point but i would prefer to open a dedicated issue

@dyladan The websocket handshake is done in http, so we could use that i believe. It depend if we want one trace per connection or one trace per packet

[dyladan]

One per connection is of dubious value... Most websocket use cases are long running and encompass many user actions.

[nstawski]

I would love to take this task. Would take me some time to solve though.

[vmarchaud]

@nstawski Feel free to ping me if you need any help or guidance on that, i've already looked up on how to implement that in the past.

[vmarchaud]

Moving to contrib repo, also @nstawski did you started to work on that ?

[dajulia3]

I for one would love this on both the node and browser side. I'd happily modify my payload with trace/span info to get tracing. Has anyone started to work on a solution for this? @vmarchaud

[dyladan]

@dajulia3 I think nobody is currently working on it. @nstawski started working on it a while ago but she's not been involved in the project recently

[vmarchaud]

No sign from @nstawski, i'll assign it to you @dajulia3 then