ioredis: `connect` instrumentation does not report correct duration and does not report failure

[blumamir]

What version of OpenTelemetry are you using?

v0.13.0

What version of Node are you using?

12

What did you do?

If possible, provide a recipe for reproducing the error.
While there is no redis server on localhost, I run the following code:

const Redis = require("ioredis");
const redis = new Redis();

What did you expect to see?

Expected to see spans of connect with an error indication (as the connect failed), and expected the duration to contain the full length of the operation.

What did you see instead?

Spans are reported with CanonicalCode.OK (StatusCode.UNSET in master), and the duration only tracks the connect function call, and not including the time until the callback is called.

[obecny]

current version of ioredis plugin is 0.11 it is not compatible with core version > 0.12 - the same as any other plugins. Contrib repo needs to be released first, there is an opened PR for new release I created last week which needs approves first.

[blumamir]

current version of ioredis plugin is 0.11 it is not compatible with core version > 0.12 - the same as any other plugins. Contrib repo needs to be released first, there is an opened PR for new release I created last week which needs approves first.

This bug is not related to your changes.

Look at ioredis plugin code here:

    try {
      const client = original.apply(this, arguments); // original here is `redis.connect` and returns a promise.
      endSpan(span, null);
      return client;
    } catch (error) {
      endSpan(span, error);
      throw error;
    }

If the original callback or promise returns with error, nothing is setting the span to error in the plugin.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.