Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-instrumentation-nestjs-core - kills the ability to define interceptors on the handler level #676

Open
danshapir opened this issue Sep 26, 2021 · 5 comments
Assignees
Labels
bug Something isn't working never-stale pkg:instrumentation-nestjs-core priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@danshapir
Copy link

What version of OpenTelemetry are you using?

0.25

What version of Node are you using?

16

What did you do?

Adding the opentelemetry-instrumentation-nestjs-core creates a scenario where using the
@UseInterceptors(WHAT_EVER) on the handler level (meaning a method), doesn't work! Those were 11 hours of evil debugging.

What did you expect to see?

What did you see instead?

Additional context

@danshapir danshapir added the bug Something isn't working label Sep 26, 2021
@austonpramodh
Copy link

austonpramodh commented Oct 15, 2021

I see that metadata assigned with the decorator also gets messed up.

export const isPublicMetaDataKey = "isPublic";
export const Public = (): CustomDecorator<string> => SetMetadata(isPublicMetaDataKey, true);

if I have Public() on a handler, this.reflector.get<boolean>(isPublicMetaDataKey, context.getHandler()); doesn't get the value.

[Update]
#633 is more relevant for this comment.

#633 (comment)

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 20, 2021
@danshapir
Copy link
Author

Still not working

@vmarchaud vmarchaud added never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers and removed stale labels Dec 20, 2021
@matteoga
Copy link
Contributor

i think #796 should have fixed this and similar issues

@dyladan
Copy link
Member

dyladan commented Sep 21, 2022

@danshapir can you confirm that this is fixed by #796 ?

@dyladan dyladan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Sep 28, 2022
@rauno56 rauno56 added the priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working never-stale pkg:instrumentation-nestjs-core priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Development

No branches or pull requests

6 participants