Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchSpanProcessor doesn't cancel after export timeout duration #1860

Open
srikanthccv opened this issue May 19, 2021 · 1 comment
Open

BatchSpanProcessor doesn't cancel after export timeout duration #1860

srikanthccv opened this issue May 19, 2021 · 1 comment
Labels
bug Something isn't working triaged

Comments

@srikanthccv
Copy link
Member

Python implementation of BatchSpanProcessor doesn't cancel the export call after the EXPORT_TIMEOUT duration. An end user can pass a value or set an env var OTEL_BSP_EXPORT_TIMEOUT to instruct how long processor can wait for export before cancelling. Python implementation doesn't use it and waits for exporter to return https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py#L330-L336. Looking at the go implementation for comparison https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/trace/batch_span_processor.go#L213 it does cancel after export timeout. I am wondering if there was any deliberate reason for not doing (there is no easy way to achieve it in python?).

@srikanthccv srikanthccv added the bug Something isn't working label May 19, 2021
@github-actions
Copy link

This issue was marked stale due to lack of activity. It will be closed in 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

1 participant