Zblue hfp batch #118
Open
Zblue hfp batch #118
+169
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse. bug: v/78002 Report call struct pointer when CLCC response to allow the upper layer to match the call in the response with the pointer provided in the callback. Signed-off-by: YuhengLi <[email protected]>
bug: v/78002 Rootcause: The CLCC API does not report when it finishes, app cannot know whether the CLCC procedure has ended. Signed-off-by: liyuheng <[email protected]>
…C_NEG is enabled bug: v/74979 Rootcause: bcs_handle call bt_hfp_hf_set_codecs and bt_hfp_hf_select_codec without using new Z_API marco. Signed-off-by: YuhengLi <[email protected]>
expliyh
force-pushed
the
zblue-hfp-batch
branch
2 times, most recently
from
03ee85f to
c6779d4
Compare
gzh-terry
reviewed
Nov 27, 2025
| /** Vendor specific / custom AT command callback | ||
| * | ||
| * If this callback is provided it will be called whenever an AT command | ||
| * is received from the HF that is not recognized and handled by the |
gzh-terry
reviewed
Nov 27, 2025
| * the CMEE setting. | ||
| * - ret == 0: The command was handled successfully and the stack will | ||
| * send the standard "OK" final result code. | ||
| * - ret > 0 : The application is responsible for sending all responses, |
Contributor
There was a problem hiding this comment.
Should this one be a ret = -EINPROGRESS?
gzh-terry
reviewed
Nov 27, 2025
| /** @brief Vendor specific command callback | ||
| * | ||
| * If this callback is provided it will be called whenever the | ||
| * vendor specific command is received from AG. |
Contributor
There was a problem hiding this comment.
How do we distinguish "vendor specific" result codes?
Is it any result codes that are not recognized?
Or it is the result codes that are received between bt_hfp_hf_send_vendor and a final OK?
Try to clarify this in the document.
Contributor
There was a problem hiding this comment.
BTW, command -> result code
gzh-terry
reviewed
Nov 27, 2025
| * @param hf HFP HF object. | ||
| * @param response Vendor specific response string. | ||
| */ | ||
| void (*vendor_specific)(struct bt_hfp_hf *hf, const char *response); |
gzh-terry
reviewed
Nov 27, 2025
| if ((err == -ENOEXEC) && bt_ag && bt_ag->vendor_at_cmd) { | ||
| size_t copy_len; | ||
|
|
||
| copy_len = MIN(len, sizeof(ag->buffer) - 1); |
Contributor
There was a problem hiding this comment.
Check the length and print an error if it exceeds the buffer size.
Do not truncate it and trigger the callback as if nothing happened.
gzh-terry
reviewed
Nov 27, 2025
| size_t copy_len; | ||
|
|
||
| copy_len = MIN(len, sizeof(ag->buffer) - 1); | ||
| memcpy(ag->buffer, data, copy_len); |
Contributor
There was a problem hiding this comment.
Use snprintf to add this \0
gzh-terry
reviewed
Nov 27, 2025
| } | ||
|
|
||
| err = bt_ag->vendor_at_cmd(ag, ag->buffer); | ||
| if (err > 0) { |
Contributor
There was a problem hiding this comment.
Remove this, use -EINPROGRESS
bug: v/78306 Rootcause: Add sendvendor API to send vendor-specific AT commands. Signed-off-by: liyuheng <[email protected]>
bug: v/79377 Rootcause: Add vendor_at_cmd callback and bt_hfp_ag_send_vendor API to recieve and send vendor-specific AT commands. Signed-off-by: liyuheng [email protected]
expliyh
force-pushed
the
zblue-hfp-batch
branch
from
c6779d4 to
bfb53f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.