Skip to content

Commit e39f213

Browse files
authored
fix: respect filtered elements when determining selected (#155)
1 parent 5f756b6 commit e39f213

File tree

5 files changed

+17
-6
lines changed

5 files changed

+17
-6
lines changed

.changeset/wicked-lizards-mate.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
---
2+
'@api-viewer/common': patch
3+
'@api-viewer/demo': patch
4+
'@api-viewer/docs': patch
5+
'api-viewer-element': patch
6+
'@api-viewer/tabs': patch
7+
---
8+
9+
Respect filtered elements when determining selected

packages/api-common/src/manifest.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,14 @@ export function getCustomElements(
7777

7878
export const getElementData = (
7979
manifest: Package,
80+
elements: CustomElementExport[],
8081
selected?: string
8182
): CustomElement | null => {
82-
const exports = getCustomElements(manifest);
83-
const index = selected ? exports.findIndex((el) => el?.name === selected) : 0;
83+
const index = selected
84+
? elements.findIndex((el) => el?.name === selected)
85+
: 0;
8486

85-
const element = exports[index];
87+
const element = elements[index];
8688

8789
if (!element) {
8890
return null;

packages/api-demo/src/base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ async function renderDemo(
2929

3030
const elements = getCustomElements(manifest, only);
3131

32-
const data = getElementData(manifest, selected) as CustomElement;
32+
const data = getElementData(manifest, elements, selected) as CustomElement;
3333
const props = getPublicFields(data.members);
3434

3535
return html`

packages/api-docs/src/base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ async function renderDocs(
2828

2929
const elements = getCustomElements(manifest, only);
3030

31-
const data = getElementData(manifest, selected) as CustomElement;
31+
const data = getElementData(manifest, elements, selected) as CustomElement;
3232
const props = getPublicFields(data.members);
3333
const methods = getPublicMethods(data.members);
3434

packages/api-viewer/src/base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ async function renderDocs(
3636

3737
const elements = getCustomElements(manifest, only);
3838

39-
const data = getElementData(manifest, selected) as CustomElement;
39+
const data = getElementData(manifest, elements, selected) as CustomElement;
4040
const props = getPublicFields(data.members);
4141
const methods = getPublicMethods(data.members);
4242

0 commit comments

Comments
 (0)