Skip to content

Assert when having a rom file larger than the romtype would allow in reality. #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BiFiMSX opened this issue Sep 24, 2023 · 2 comments

Comments

@BiFiMSX
Copy link

BiFiMSX commented Sep 24, 2023

image
I get this assert when I'm running a rom image in a rom type that uses a mapper chip that can't address this much in a real chip (in this case 2 MB in a KonamiSCC romtype). It shouldn't really assert in this case if you ask me.

The assert occurs when doing debug break. Connecting the debugger to openMSX works fine. It's really the debug break that triggers the assert.

@m9710797
Copy link
Contributor

Hi BiFiMSX,

Thanks for reporting!
You're right. Triggering an assert is always a bug.

Unfortunately I can't reproduce this bug :(

  • I created a (dummy) 2MB rom file.
  • Start openmsx with: openmsx dummy.rom -romtype KonamiSCC (I tried several other rom types as well)
  • Start the (old) debugger. And connect to openMSX.
  • Do a "debug break" (I tried both the break button in the debugger and the 'debug break' command in openMSX).
    This just works.

I tried the same, but then made sure I was viewing the 2MB rom in the debugger. But still no crash.
I also made sure my debugger was build with assertions enabled.

The assertion (line 99 in the debugger source code src/OpenMSXConnection.cpp) seems to suggest something went wrong with querying a debuggable. So my best guess is that it must somehow be related to the 2MB rom debuggable? I tried various things, but I really couldn't get it to crash.

BiFiMSX, how does the scenario I described above differ from what you were doing? Or any other suggestions for how I can reproduce the crash?

Thanks.

Wouter

@MBilderbeek
Copy link
Member

@BiFiMSX please let us know if the same happens with a totally different (large) ROM using the same mapper type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants