-
-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/mailer #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Feat/mailer #612
Conversation
* feat(api): add api routes for /users/me * fix(tests): api me PUT * feat(api): add delete me endpoint
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
jona159
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please check the comments before merging
|
|
||
| // Interface to load env variables | ||
| // Note these variables can possibly be undefined | ||
| // as someone could skip these varibales or not setup a .env file at all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is something missing here?
|
|
||
| mailhog: | ||
| image: mailhog/mailhog:v1.0.1 | ||
| platform: linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better omit the platform and let it pull the correct image for the current platform automatically?
| }} | ||
| > | ||
| {intl.formatMessage({ id: "support" })} {} | ||
| <Link href="mailto:[email protected]?Subject=Email%20Best%C3%A4tigen%20f%C3%BCr%[email protected]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm i am wondering if we should use the email from Matthias here?
| }} | ||
| > | ||
| {intl.formatMessage({ id: "support" })} {} | ||
| <Link href="mailto:[email protected]?Subject=Email%20Best%C3%A4tigen%20f%C3%BCr%[email protected]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as below
Fixes #609