Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid issue_introduction.patch files #60

Open
aarora4 opened this issue Mar 11, 2025 · 0 comments
Open

Invalid issue_introduction.patch files #60

aarora4 opened this issue Mar 11, 2025 · 0 comments

Comments

@aarora4
Copy link

aarora4 commented Mar 11, 2025

Issue

The issue_introduction.patch seems to be invalid for 32 instances, causing the setup_expensify setup script called from run.sh to fail at the line patch -p1 < "/app/tests/issues/$ISSUE_ID/issue_introduction.patch"

Reproduction Steps:

Take issue 203 as an example.

  1. Build the swelancer docker container based on the README.md
  2. Run the container with an overrided entrypoint for debugging docker run -d --name my_container --entrypoint "" swelancer:latest tail -f /dev/null
  3. Attach to the container.
  4. git reset --hard origin/master
  5. git checkout <commit_id>, in this case git checkout da2e6688c3f16e8db76d2bcf4b098be5990e8968
  6. patch -p1 < "/app/tests/issues/{issue_id}/issue_introduction.patch", in this case patch -p1 < "/app/tests/issues/203/issue_introduction.patch"

Output:

patching file src/components/MoneyRequestConfirmationList.tsx
patching file src/components/SelectionList/BaseSelectionList.tsx
patching file src/languages/en.ts
patching file src/languages/es.ts
patching file src/pages/tasks/NewTaskPage.tsx
patch: **** malformed patch at line 180: @@ -145,14 +179,14 @@ function NewTaskPage({route}: NewTaskPageProps) {

There are 178 / 381 instances with an issue_introduction.patch. The majority of them are working properly, but I have encountered these patch failures with the issue_introduction.patch on the following 32 issue_ids=[203, 208, 210, 211, 213, 216, 217, 220, 221, 226, 229, 231, 246, 255, 266, 271, 275, 277, 297, 299, 300, 301, 303, 313, 320, 324, 338, 340, 342, 345, 355, 370]

Additional question:

Image

There is this figure in the paper showing a success rate of 7.7% on instances with a task price >= $2k. This implies there are 13 samples, or some multiple of 13, with value >=$2k. However, if you query the swelancer_tasks.csv, you will only find 2 samples that meet this criterion. What is the reason for this mismatch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant