Fix Ruff formatting when meta=none (#940)

Also, does a bunch of test refactoring to make future changes like this
easier by:

- Putting `Config` in a fixture, since most tests need it but don't care
what's in it
- Deleting more of the mocked tests, since they don't test much and are
hard to read

To get coverage back up, this means adding more functional e2e tests

---------

Co-authored-by: Dylan Anthony <[email protected]>

Author: dbanty

.changeset/fix_ruff_formatting_for_metanone.md

@@ -0,0 +1,14 @@
+---
+default: patch
+---
+
+# Fix Ruff formatting for `--meta=none`
+
+PR #940 fixes issue #939. Thanks @satwell!
+
+Due to the lack of `pyproject.toml`, Ruff was not getting configured properly when `--meta=none`.
+As a result, it didn't clean up common generation issues like duplicate imports, which would then cause errors from 
+linters.
+
+This is now fixed by changing the default `post_hook` to `ruff check . --fix --extend-select=I` when `--meta=none`.
+Using `generate --meta=none` should now be almost identical to the code generated by `update`.

.changeset/include_the_up_rule_for_generated_ruff_config.md

@@ -0,0 +1,8 @@
+---
+default: minor
+---
+
+# Include the `UP` rule for generated Ruff config
+
+This enables [pyupgrade-like improvements](https://docs.astral.sh/ruff/rules/#pyupgrade-up) which should replace some 
+`.format()` calls with f-strings.

.github/check_for_changes.py

@@ -149,11 +149,6 @@ jobs:
           pip install pdm
           python -m venv .venv
           pdm install
-      - name: Regenerate Integration Client
-        run: |
-          pdm run openapi-python-client update --url http://localhost:3000/openapi.json --config integration-tests-config.yaml --meta pdm
-      - name: Check for any file changes
-        run: python .github/check_for_changes.py
       - name: Cache Generated Client Dependencies
         uses: actions/cache@v3
         with:

.github/workflows/checks.yml

@@ -0,0 +1,2 @@
+post_hooks:
+  - echo "this should fail" && exit 1

end_to_end_tests/custom_post_hooks.config.yml

@@ -34,9 +34,7 @@ def _get_kwargs(
 
     _kwargs: Dict[str, Any] = {
         "method": "get",
-        "url": "/parameter-references/{path_param}".format(
-            path_param=path_param,
-        ),
+        "url": f"/parameter-references/{path_param}",
         "params": params,
         "cookies": cookies,
     }

end_to_end_tests/golden-record/my_test_api_client/api/parameter_references/get_parameter_references_path_param.py

@@ -21,9 +21,7 @@ def _get_kwargs(
 
     _kwargs: Dict[str, Any] = {
         "method": "delete",
-        "url": "/common_parameters_overriding/{param}".format(
-            param=param_path,
-        ),
+        "url": f"/common_parameters_overriding/{param_path}",
         "params": params,
     }
 

end_to_end_tests/golden-record/my_test_api_client/api/parameters/delete_common_parameters_overriding_param.py

@@ -21,9 +21,7 @@ def _get_kwargs(
 
     _kwargs: Dict[str, Any] = {
         "method": "get",
-        "url": "/common_parameters_overriding/{param}".format(
-            param=param_path,
-        ),
+        "url": f"/common_parameters_overriding/{param_path}",
         "params": params,
     }
 

end_to_end_tests/golden-record/my_test_api_client/api/parameters/get_common_parameters_overriding_param.py

@@ -31,9 +31,7 @@ def _get_kwargs(
 
     _kwargs: Dict[str, Any] = {
         "method": "get",
-        "url": "/same-name-multiple-locations/{param}".format(
-            param=param_path,
-        ),
+        "url": f"/same-name-multiple-locations/{param_path}",
         "params": params,
         "cookies": cookies,
     }

end_to_end_tests/golden-record/my_test_api_client/api/parameters/get_same_name_multiple_locations_param.py

@@ -16,12 +16,7 @@ def _get_kwargs(
 ) -> Dict[str, Any]:
     _kwargs: Dict[str, Any] = {
         "method": "get",
-        "url": "/multiple-path-parameters/{param4}/something/{param2}/{param1}/{param3}".format(
-            param4=param4,
-            param2=param2,
-            param1=param1,
-            param3=param3,
-        ),
+        "url": f"/multiple-path-parameters/{param4}/something/{param2}/{param1}/{param3}",
     }
 
     return _kwargs