-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
English (UK) language not auto-correcting correct spellings #439
Comments
I've tested this and can confirm this. |
Also happening for me! |
I looked in to the dictionary for britisch english and the reason simply seems to be that the frequency for color is set to a higher value:
|
I'm having this problem too. E.g. UK English words with an "s" - e.g. maximise, organise - get changed to the US spelling with a "z". |
I just checked the lineage os dictionary and the google dictionary and it seems both have the same problem as OpenBoard. (They're probably even using the same dictionary.) And since the source of FrequencyWords, OpenSubtitles doesn't distinguish between en_US and en_GB its not that easy to generate them myself. |
After seeing this commit: wordmage@566ad21, I investigated this issue a bit further and it seems that the color/colour issue is a bit different to other auto-correction issues. In the color/colour case the dictionaries in /dictionaries have the same information. But this isn't the case for other words. For example regarding finalized/finalised: |
Bug still outstanding. With language set to UK, autocorrect always suggests the US spelling. (e.g. authorized, color, labor.) |
@Mateus109 With the current release or did you use the changes in #528? |
I'd be happy to test a beta package but I can't do building from source. |
@jnnkB I was using the current F-Droid build but, having manually imported main_en_gb.dict and built OpenBoard from source, this has fixed the problem. I assume main_en_gb.dict will be included in future releases. Now I just need to get a Finnish dictionary added! :) |
@Mateus109 That sounds good. |
Testing complete? |
@LinuxOnTheDesktop I was unable to install it (the unsigned apk linked above) on my phone. I confirmed the install and then it just said "App not installed". |
I can confirm this issue. Even the suggestions I receive are based on US spelling (I type "autori" and it suggests "authorize") |
@Knusper I think they've fixed it, but it seems they're not publishing releases to fdroid (last one 5 months ago) so you need some clever developer set up to test the newer builds. I assume it takes time to publish releases and the project is short on that. |
Still happens as of v1.4.5 |
I created PR #528 for this a while ago that should fix this issue, but it hasn't been merged yet, because, as @MajeurAndroid pointed out on that PR, @dslul doesn't want to include every dictionaries for package size reasons for now. So we'll have to wait for @dslul to merge PR #528 or for PR #569 (currently available only on feature-external-dicts branch) to be included in the next release.
|
This seems to be true for the other English variants as well. En_AU suffers from the same issue, for example. ^ Would it not be possible to download the dictionary on demand, rather than packaging them all in? (Although, you'd expect that the same dictionaries would have already been loaded into the keyboard). |
There has already been quite a discussion about this in #47. TLDR: The simplest solution would require internet access for the app, which was rejected due to privacy concerns. There are proposals for different methods of importing dictionaries, but none have been implemented so far. |
Loading external dictionaries is possible in the feature-external-dicts branch, but it looks like there was no work / testing done for quite a while now |
It is frankly ridiculous that a keyboard would only include US English because devs refuse to either bundle other dictionaries or provide means of importing others. It's absurd that this issue could remain open for over two years. |
@unaszplodr I feel your frustration, as I'm in UK, but it is worth remembering that the devs here are doing their work for free, and that an app like this is complex and takes a lot of work. I still prefer this keyboard to others that are available, though I'd dearly love to colourise my prose rather than colorize it! But there are, of course, no shortage of keyboard apps that you pay for with your data, or through intrusive ads, and others with different featuresets in the F-droid repos |
Is there a temporary fix until the fix is implemented? |
If you want to try, you can use https://github.com/Helium314/openboard/releases/tag/v1.4.5_compress The feature has been quietly sitting around for a year now, not sure why. Latest comment was #569 (comment) |
So I just tried to install it and the UK dictionary was not preinstalled though there is now the option to add dictionaries. I have looked at https://github.com/openboard-team/openboard/tree/master/app/src/main/res/raw |
@artfulrobot Here's the thing: I can actually select British English in the preferences. If you're going to omit English English, don't pretend it is installed by having it default to US English instead! We're talking about a keyboard application with limited language support and no means of extending it. A keyboard application. @Helium314 Why on earth that that would sit around unmerged for a year in an active project?! Thanks for your work. My problem is that Openboard came installed with the IodeOS firmware I'm using. I can't revert to an AOSP package that isn't there, so unless I do complete Android builds myself for the sake of a dictionary, I'm locked into a keyboard developed by people who only seem to give a crap about those who speak American English. |
You can find some files for https://github.com/remi0s/aosp-dictionary-tools in https://github.com/LineageOS/android_packages_inputmethods_LatinIME/tree/lineage-20.0/dictionaries. But I remember I had found some already compiled dictionaries somewhere a while ago... Edit: you can use the one from a PR here: https://github.com/openboard-team/openboard/pull/528/files |
@unaszplodr I tried to change the package name, so it could be installed along normal OpenBoard, but still it didn't work... looks like further changes are required. If you have root privileges (or access to system folder from TWRP), you could remove the openboard APK, which should allow you to install the changed version. But I never tried this, and in worst case it might break your system so you'd need to re-flash the OS.
Properly reviewing these changes takes some time, as no one wants a buggy keyboard. And it looks like the devs can't or don't want to spend a lot of time working on OpenBoard. |
@Helium314 |
@Helium314 Altering the manifest didn't work? Oh well, worth a try. Thanks. Yeah, I guess I could switch the packages via the superuser, but I rather suspect it will break OTA updates. I'm probably going to end up having to do full builds myself... And here I was thinking I'd finally found a distribution I wouldn't have to mess about with. |
Describe the bug
When selecting the English (UK) language, words are auto-corrected to the American spelling.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
English (UK) spellings should not be auto-corrected to the American spelling and should remain as entered. Or if misspelled, should auto-correct to the English (UK) spelling.
Smartphones:
and also,
The text was updated successfully, but these errors were encountered: