-
Notifications
You must be signed in to change notification settings - Fork 291
Re-review acknowledgement assumes a durable review comment already exists #581
Copy link
Copy link
Closed
Labels
P3Low-risk cleanup, docs, polish, ergonomics, or speculative feature.Low-risk cleanup, docs, polish, ergonomics, or speculative feature.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-live-reproClawSweeper needs live local, crabbox, or manual validation to confirm this issue.ClawSweeper needs live local, crabbox, or manual validation to confirm this issue.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.impact:ux-frictionUser-facing flow adds avoidable confusion or support burden without fully blocking progress.User-facing flow adds avoidable confusion or support burden without fully blocking progress.issue-rating: 🐚 platinum hermitGood issue quality with a plausible reproduction path needing some confirmation.Good issue quality with a plausible reproduction path needing some confirmation.
Description
Metadata
Metadata
Assignees
Labels
P3Low-risk cleanup, docs, polish, ergonomics, or speculative feature.Low-risk cleanup, docs, polish, ergonomics, or speculative feature.clawsweeper:linked-pr-openClawSweeper found an open linked pull request for this issue.ClawSweeper found an open linked pull request for this issue.clawsweeper:needs-live-reproClawSweeper needs live local, crabbox, or manual validation to confirm this issue.ClawSweeper needs live local, crabbox, or manual validation to confirm this issue.clawsweeper:no-new-fix-prClawSweeper does not recommend queueing a new automated fix PR for this issue.ClawSweeper does not recommend queueing a new automated fix PR for this issue.impact:ux-frictionUser-facing flow adds avoidable confusion or support burden without fully blocking progress.User-facing flow adds avoidable confusion or support burden without fully blocking progress.issue-rating: 🐚 platinum hermitGood issue quality with a plausible reproduction path needing some confirmation.Good issue quality with a plausible reproduction path needing some confirmation.
Type
Fields
Priority
None yet
I ran into this while using
GitHub: On PR #576,@clawsweeper re-reviewwas accepted into the exact-review queue before any durable ClawSweeper review comment existed, but the command-status reply promised that the existing review comment would be edited in place. Both enqueue-only workflows completed successfully; this report is about the inaccurate acknowledgement, not review-queue latency.I expected the acknowledgement to remain accurate for both supported paths: create the first durable review placeholder when none exists, or update the existing durable review comment.
Instead, the successful re-review response always says that the existing ClawSweeper review comment will be edited in place, including when no durable review marker exists yet.
I traced this to the dispatched
re_reviewbranch ofrenderResponseemitting a fixed existing-comment sentence. Its inputs do not carry review-comment existence, while the documented review lifecycle supports both creating a marker-backed placeholder and editing an existing durable comment; the focused test currently asserts the fixed sentence.I verified that with the live PR having two accepted
@clawsweeper re-reviewcommands, one surviving command-status acknowledgement, no durableclawsweeper-reviewmarker, and no posted review. Both repository-dispatch workflow runs completed successfully in enqueue-only mode. Currentorigin/mainunconditionally emits and tests the existing-comment sentence, whiledocs/pr-review-comments.mdsays a review shard creates a marker-backed placeholder when no durable comment exists.The raw artifacts I used are: #576 (comment) ; https://github.com/openclaw/clawsweeper/actions/runs/29362584394 ; https://github.com/openclaw/clawsweeper/actions/runs/29367358183 ;
clawsweeper/src/repair/comment-router-core.ts
Lines 2155 to 2169 in eda9768
clawsweeper/test/repair/comment-router-core.test.ts
Lines 3150 to 3172 in eda9768
clawsweeper/docs/pr-review-comments.md
Lines 21 to 33 in eda9768
Reproduction: Open a pull request with no comment containing
<!-- clawsweeper-review item=<number> -->, post@clawsweeper re-review, then inspect the bot command-status reply. On PR #576, comment 4973212500 says the existing review comment will be edited even though the issue-comment API has no durable review marker. The enqueue-only runs 29362584394 and 29367358183 both succeeded, so the command was accepted rather than rejected.Environment: openclaw/clawsweeper origin/main at eda9768; GitHub command router; observed July 14, 2026 on PR #576 at head a3faecc.
Raw observation:
On openclaw/clawsweeper PR 576, post @clawsweeper re-review before any durable ClawSweeper review comment exists1