Harden and annotate Slopwatch findings (#716)

Merged Slopwatch hardening and audited inline suppressions.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: shanselman

src/OpenClaw.Connection/GatewayConnectionManager.cs

@@ -289,6 +289,7 @@ tunnel.SshPort is < 1 or > 65535 ||
                 {
                     await lifecycle.ConnectAsync(ct);
                 }
+                // slopwatch-ignore: SW003 Shutdown cancellation or disposal is expected and the caller already preserves the safe state.
                 catch (OperationCanceledException) { }
                 catch (Exception ex)
                 {
@@ -654,6 +655,7 @@ private bool TryScheduleOperatorTokenRecovery(string message, long gen)
                 if (Interlocked.Read(ref _generation) != gen || _disposed) return;
                 await ReconnectAsync();
             }
+            // slopwatch-ignore: SW003 Shutdown cancellation or disposal is expected and the caller already preserves the safe state.
             catch (ObjectDisposedException) { }
             catch (Exception ex)
             {
@@ -1239,6 +1241,7 @@ private async Task DisposeCoreAsync()
         {
             if (semaphoreEntered)
             {
+                // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
                 try { _transitionSemaphore.Release(); } catch { }
                 _transitionSemaphore.Dispose();
             }

src/OpenClaw.Connection/GatewayRegistry.cs

@@ -13,6 +13,7 @@ public sealed class GatewayRegistry
     private readonly string _filePath;
     private readonly string _gatewaysDir;
     private readonly IFileSystem _fs;
+    private readonly IOpenClawLogger _logger;
     private List<GatewayRecord> _records = [];
     private string? _activeId;
 
@@ -29,9 +30,11 @@ public sealed class GatewayRegistry
     /// </summary>
     /// <param name="dataDir">Root data directory (e.g. %APPDATA%/OpenClawTray).</param>
     /// <param name="fs">Filesystem abstraction for testability.</param>
-    public GatewayRegistry(string dataDir, IFileSystem? fs = null)
+    /// <param name="logger">Optional diagnostics sink for persistence problems.</param>
+    public GatewayRegistry(string dataDir, IFileSystem? fs = null, IOpenClawLogger? logger = null)
     {
         _fs = fs ?? RealFileSystem.Instance;
+        _logger = logger ?? NullLogger.Instance;
         _filePath = Path.Combine(dataDir, "gateways.json");
         _gatewaysDir = Path.Combine(dataDir, "gateways");
     }
@@ -164,9 +167,9 @@ public void Load()
                 }
             }
         }
-        catch (JsonException)
+        catch (JsonException ex)
         {
-            // Corrupted file — start fresh
+            _logger.Warn($"Gateway registry file '{_filePath}' is not valid JSON; starting with an empty registry. {ex.Message}");
         }
     }
 

src/OpenClaw.Connection/SshTunnelService.cs

@@ -106,6 +106,7 @@ public void Stop()
         }
         finally
         {
+            // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
             try { _process.Dispose(); } catch { }
             _process = null;
             _lastSpec = null;
@@ -172,6 +173,7 @@ private void StartProcess(string user, string host, int remotePort, int localPor
                 LastError = $"SSH tunnel exited unexpectedly with code {exitCode}.";
                 StartedAtUtc = null;
                 Status = TunnelStatus.Failed;
+                // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
                 try { process.Dispose(); } catch { }
                 _process = null;
                 _lastSpec = null;

src/OpenClaw.SetupEngine.UI/LogFileLauncher.cs

@@ -65,6 +65,7 @@ public static void RevealInExplorer(string? logPath)
                 });
             }
         }
+        // slopwatch-ignore: SW003 Audited non-critical fallback is intentional and the caller preserves safe behavior without this work.
         catch
         {
             // best effort — the link is informational

src/OpenClaw.SetupEngine.UI/Pages/PermissionsPage.xaml.cs

@@ -106,6 +106,7 @@ private static FrameworkElement BuildRow(PermDef perm, string status, bool grant
             btn.Click += async (_, _) =>
             {
                 try { await Windows.System.Launcher.LaunchUriAsync(new Uri(uri)); }
+                // slopwatch-ignore: SW003 UI helper action is best-effort and failure should not break the owning UI flow.
                 catch { /* best effort */ }
             };
             actionCol = btn;

src/OpenClaw.SetupEngine.UI/Pages/WizardPage.xaml.cs

@@ -626,6 +626,7 @@ private void StartConsoleTail()
                     AppendConsoleLine(message);
                 });
             }
+            // slopwatch-ignore: SW003 Audited non-critical fallback is intentional and the caller preserves safe behavior without this work.
             catch
             {
             }
@@ -636,7 +637,9 @@ private void StopConsoleTail()
     {
         var tail = _consoleTail;
         _consoleTail = null;
+        // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
         try { tail?.Stop(); } catch { }
+        // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
         try { tail?.Dispose(); } catch { }
     }
 
@@ -778,6 +781,7 @@ private async Task CancelCurrentSessionAsync()
         if (_client != null && !string.IsNullOrWhiteSpace(_sessionId))
         {
             try { await _client.SendWizardRequestAsync("wizard.cancel", new { sessionId = _sessionId }, timeoutMs: 10_000); }
+            // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
             catch { }
         }
         await DisconnectAsync();
@@ -809,6 +813,7 @@ private async Task DisconnectAsync()
         if (client == null) return;
         _client = null;
         client.StatusChanged -= OnWizardClientStatusChanged;
+        // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
         try { await client.DisconnectAsync(); } catch { }
         client.Dispose();
     }

src/OpenClaw.SetupEngine.UI/WizardConsoleTail.cs

@@ -87,6 +87,7 @@ public void Start(Action<string> onMessage)
             var extracted = TryExtractConsoleMessage(e.Data);
             if (extracted == null) return;
             try { onMessage(extracted); }
+            // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
             catch { /* never let a UI mistake kill the tail */ }
         };
         process.ErrorDataReceived += (_, e) =>
@@ -124,7 +125,9 @@ public void Stop()
             if (!process.HasExited)
                 process.Kill(entireProcessTree: true);
         }
+        // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
         catch { /* already gone */ }
+        // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
         try { process.Dispose(); } catch { }
     }
 

src/OpenClaw.SetupEngine/AtomicFile.cs

@@ -51,8 +51,9 @@ private static void TryDeleteTemp(string tempPath)
             if (File.Exists(tempPath))
                 File.Delete(tempPath);
         }
-        catch
+        catch (Exception ex)
         {
+            System.Diagnostics.Debug.WriteLine($"Failed to delete temporary file '{tempPath}': {ex.Message}");
         }
     }
 }

src/OpenClaw.SetupEngine/CommandRunner.cs

@@ -176,6 +176,7 @@ public Task<CommandResult> RunInWslAsync(
 
     private static void TryKill(Process process)
     {
+        // slopwatch-ignore: SW003 Cleanup is best-effort; failure cannot improve caller state and the original outcome is preserved.
         try { process.Kill(entireProcessTree: true); } catch { /* best effort */ }
     }
 

src/OpenClaw.SetupEngine/ExistingConfigDetector.cs

@@ -52,9 +52,9 @@ public static ExistingConfig Detect(string dataDir, string targetDistroName)
                 hasDistro = distros.Any(d => d.Equals(targetDistroName, StringComparison.OrdinalIgnoreCase));
             }
         }
-        catch
+        catch (Exception ex)
         {
-            // WSL not available.
+            System.Diagnostics.Debug.WriteLine($"WSL distro detection failed: {ex.Message}");
         }
 
         var hasIdentity = false;