build: Don't branch or tag this in the named release#1310
build: Don't branch or tag this in the named release#1310farhaanbukhsh merged 2 commits intomainfrom
Conversation
we don't want a release branch made on the docs repo, because so much documentation happens between the cut and the release and backporting so many docs changes is a big cognitive overhead
|
Ah wait, I realize now that even though we don't want the repo branched (release/ulmo), we do want it tagged (release/ulmo.1, release/ulmo.2, etc.). So, maybe this isn't the right change. I'll leave this open as a draft for @sarina and @farhaanbukhsh to discuss, but feel free to close if this isn't right. |
|
Yeah, agree that we want this repo to have an Ulmo branch, but in a nonstandard way: that the Ulmo branch is created on the day of the release, instead of the cut. I don't know the best way to do that. Is it perhaps that I would hard-delete the current Ulmo branch and recreate it before the release date? |
|
@sarina yes lets delete the Ulmo branch and in the release manager doc, we can add the step to manually create |
kdmccormick
requested review from
farhaanbukhsh and
sarina
and removed request for
sarina
|
sgtm! I added a comment to the catalog-info file, let me know if it looks good. |
farhaanbukhsh
left a comment
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍 LGTM
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ✅ Includes documentation
| # This is because a lot of documentation happens between the cut date and the X.1 release date; | ||
| # rather than backporting all those docs, we'd rather just make the branch late. | ||
| # So, we do not delcare a `openedx.org/release:` key here, because that would confuse the release script. | ||
| # Instead, the community Release Manager will manually create the `release/X` branch at the right time. |
There was a problem hiding this comment.
Will the release manager ever see this note?
There was a problem hiding this comment.
There was a problem hiding this comment.
3 participants
@sarina , from https://discuss.openedx.org/t/git-checkout-release-ulmo/17466 :
Is it fair to then remove this line from catalog-info so that it's not auto-tagged in the future?