Conversation
|
Thanks for the pull request, @Kelketek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1729837 to
5602e89
Compare
|
@samuelallan72 This is ready for you. |
samuelallan72
left a comment
There was a problem hiding this comment.
Thanks @Kelketek ! In general things look pretty good. I left some requests though. :)
| +--------------+-------------------------------+----------------+--------------------------------+ | ||
| | Review Date | Working Group Reviewer | Release |Test situation | | ||
| +--------------+-------------------------------+----------------+--------------------------------+ | ||
| | | | | | |
There was a problem hiding this comment.
@Kelketek please add your information here to confirm they work - see #1376 (comment) for context.
| ########################## | ||
|
|
||
| Before you can add an embedded PDF to your course, you must enable the pdf embed | ||
| tool in Studio or OLX (open learning XML). |
There was a problem hiding this comment.
| tool in Studio or OLX (open learning XML). | |
| tool in Studio. |
It's confusing to me, mentioning to enable it in the OLX, when there is no example of enabling it in the OLX.
| Before you can add an embedded PDF to your course, you must enable the pdf embed | ||
| tool in Studio or OLX (open learning XML). | ||
|
|
||
| To enable the pdf embed tool in Studio, you add the ``"pdf"`` key to the |
There was a problem hiding this comment.
| To enable the pdf embed tool in Studio, you add the ``"pdf"`` key to the | |
| To enable the pdf embed tool in Studio, add the ``"pdf"`` key to the |
|
|
||
| .. tags:: educator, how-to | ||
|
|
||
| #. On the Course Outline page, open the unit where you want to add the PDF. |
There was a problem hiding this comment.
Since the PDF block will be disabled by default, I think this needs a pre-requisite step of "ensure the pdf tool is enabled in the course".
There was a problem hiding this comment.
I feel like this would be a more useful screenshot if it included some of the Studio UI (eg. with the edit button, etc.). That might provide some more context, especially for where it's used to demonstrate what it should look like once you've selected the pdf component to add in studio.
| If you do not have an existing URL for your PDF, you may upload the PDF by | ||
| :ref:`adding it as a handout<Add Course Updates and Handouts>` and copy the | ||
| URL of the resulting handout. |
There was a problem hiding this comment.
Do you mean adding a course file ( https://docs.openedx.org/en/latest/educators/how-tos/course_development/manage_course_files.html#add-course-files ) instead?
I don't think a course handout is relevant here.
| PDF display is handled by the browser's built-in PDF viewer. The option to hide the download button will not hide the browser's built-in download button if it provides one. A determined learner will always be able to download a PDF. | ||
|
|
||
|
|
||
| #. In the **Source document URL** field, optionally add the URL to the source |
There was a problem hiding this comment.
This list numbering is restarted due to the note block above. Perhaps the note block can be indented to not break the list flow?
Description
This merge request documents the PDF Block. It documents the block's current functionality as initially contributed, and follow-up PRs will be added as other elements of the PDF Proposal are completed, to keep the documentation up to date.
Supporting information
PDF Block Proposal
Dependencies
The merge request for adding the PDF block to XBlocks-Contrib should be merged before merging this PR.
Once that PR is merged, one more PR is expected for updating the version of xblocks-contrib in edx-platform. This has not yet been created.
Deadline
This documentation must be merged before Verawood, which is when the PDF block will be standardized.