Inconsistent logic between ENABLE_COURSE_DISCOVERY and NON_BROWSABLE_COURSES

[PKulkoRaccoonGang]

Description

The current logic for displaying the course catalog link differs depending on whether the user is logged in or logged out, and relies on two separate settings: ENABLE_COURSE_DISCOVERY and NON_BROWSABLE_COURSES.

• Logged out users: The catalog link is shown if ENABLE_COURSE_DISCOVERY is true, regardless of NON_BROWSABLE_COURSES.

• Logged in users: The catalog link is shown if NON_BROWSABLE_COURSES is false, regardless of ENABLE_COURSE_DISCOVERY.

This behavior is consistent with existing implementations in both the edx-platform and the MFE, but the relationship between the two settings can be confusing and non-intuitive.

The dual-setting logic makes it unclear which configuration should be used to control catalog visibility. It may be worth reconsidering whether both flags should be taken into account together.

More context