fix: example app plugin rendering and remove LMS authentication (#66)

jsnwesson · web-flow · commit c1aa33fc4799 · 2024-05-21T13:52:41.000-07:00
* refactor: remove `frontend-component-header` and `frontend-component-footer` dependencies in example apps
* chore: remove auth requirement for LMS
  * enables development outside of hosted devstack and LMS
diff --git a/example-plugin-app/package-lock.json b/example-plugin-app/package-lock.json
diff --git a/example-plugin-app/package.json b/example-plugin-app/package.json
@@ -17,8 +17,6 @@
     "react": "^17.0.0",
     "react-dom": "^17.0.0",
     "react-router-dom": "^6.22.1",
-    "regenerator-runtime": "^0.14.1",
-    "@edx/frontend-component-footer": "14.0.0",
-    "@edx/frontend-component-header": "5.3.1"
+    "regenerator-runtime": "^0.14.1"
   }
 }
diff --git a/example/env.config.jsx b/example/env.config.jsx
@@ -131,7 +131,7 @@ const config = {
         {
           op: PLUGIN_OPERATIONS.Insert,
           widget: {
-            id: 'inserted_direct_plugin',
+            id: 'insert_modular_direct_plugin',
             type: DIRECT_PLUGIN,
             priority: 1,
             RenderWidget: ModularComponent,
@@ -149,7 +149,7 @@ const config = {
         {
           op: PLUGIN_OPERATIONS.Insert,
           widget: {
-            id: 'inserted_direct_plugin',
+            id: 'insert_direct_plugin',
             type: DIRECT_PLUGIN,
             priority: 1,
             RenderWidget: ModularComponent,
@@ -162,7 +162,7 @@ const config = {
         {
           op: PLUGIN_OPERATIONS.Insert,
           widget: {
-            id: 'inserted_direct_plugin',
+            id: 'insert_another_direct_plugin',
             type: DIRECT_PLUGIN,
             priority: 10,
             RenderWidget: PluginDirect,
diff --git a/example/package-lock.json b/example/package-lock.json
diff --git a/example/package.json b/example/package.json
@@ -18,9 +18,7 @@
     "react-dom": "^17.0.0",
     "react-router": "^6.22.3",
     "react-router-dom": "^6.22.3",
-    "regenerator-runtime": "^0.14.1",
-    "@edx/frontend-component-footer": "14.0.0",
-    "@edx/frontend-component-header": "5.3.1"
+    "regenerator-runtime": "^0.14.1"
   },
   "devDependencies": {
     "@openedx/frontend-build": "^14.0.3"
diff --git a/example/src/index.jsx b/example/src/index.jsx
@@ -36,5 +36,5 @@ subscribe(APP_INIT_ERROR, (error) => {
 initialize({
   messages: [],
   requireAuthenticatedUser: false,
-  hydrateAuthenticatedUser: true,
+  hydrateAuthenticatedUser: false,
 });
diff --git a/example/src/index.scss b/example/src/index.scss
@@ -2,6 +2,3 @@
 @import "@edx/brand/paragon/variables.scss";
 @import "@openedx/paragon/scss/core/core.scss";
 @import "@edx/brand/paragon/overrides.scss";
-
-@import "~@edx/frontend-component-header/dist/index";
-@import "~@edx/frontend-component-footer/dist/footer";
diff --git a/example/src/pluginSlots/PluginSlotWithInsert.jsx b/example/src/pluginSlots/PluginSlotWithInsert.jsx
@@ -8,7 +8,6 @@ function PluginSlotWithInsert() {
       <h2 className="pl-3">Plugin Operation: Insert</h2>
       <PluginSlot
         id="slot_with_insert_operation"
-        data-testid="testing"
       >
         <section className="bg-success p-3 text-light">
           <h3>Default Content</h3>
diff --git a/example/src/pluginSlots/PluginSlotWithModifyWrapHide.jsx b/example/src/pluginSlots/PluginSlotWithModifyWrapHide.jsx
@@ -15,7 +15,6 @@ function PluginSlotWithModifyWrapHide() {
       <h2 className="pl-3">Plugin Operation: Modify, Wrap, and Hide</h2>
       <PluginSlot
         id="slot_with_modify_wrap_hidden_operations"
-        data-testid="testing"
       >
         <ModularComponent content={content}/>
       </PluginSlot>
diff --git a/example/src/pluginSlots/PluginSlotWithModularPlugins.jsx b/example/src/pluginSlots/PluginSlotWithModularPlugins.jsx
@@ -14,7 +14,6 @@ function PluginSlotWithModularPlugins() {
       <h2 className="pl-3">Direct Plugins Using Modular Components</h2>
       <PluginSlot
         id="slot_with_modular_plugins"
-        data-testid="testing"
       >
         <ModularComponent content={content} />
       </PluginSlot>
diff --git a/example/src/pluginSlots/PluginSlotWithoutDefault.jsx b/example/src/pluginSlots/PluginSlotWithoutDefault.jsx
@@ -8,7 +8,6 @@ function PluginSlotWithoutDefault() {
       <h2 className="pl-3">Default Content Set to False</h2>
       <PluginSlot
         id="slot_without_default"
-        data-testid="testing"
       >
       </PluginSlot>
     </div>

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@`
`17`	`17`	`"react": "^17.0.0",`
`18`	`18`	`"react-dom": "^17.0.0",`
`19`	`19`	`"react-router-dom": "^6.22.1",`
`20`		`- "regenerator-runtime": "^0.14.1",`
`21`		`- "@edx/frontend-component-footer": "14.0.0",`
`22`		`- "@edx/frontend-component-header": "5.3.1"`
	`20`	`+ "regenerator-runtime": "^0.14.1"`
`23`	`21`	`}`
`24`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ function PluginSlotWithInsert() {`
`8`	`8`	`<h2 className="pl-3">Plugin Operation: Insert</h2>`
`9`	`9`	`<PluginSlot`
`10`	`10`	`id="slot_with_insert_operation"`
`11`		`- data-testid="testing"`
`12`	`11`	`>`
`13`	`12`	`<section className="bg-success p-3 text-light">`
`14`	`13`	`<h3>Default Content</h3>`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ function PluginSlotWithModifyWrapHide() {`
`15`	`15`	`<h2 className="pl-3">Plugin Operation: Modify, Wrap, and Hide</h2>`
`16`	`16`	`<PluginSlot`
`17`	`17`	`id="slot_with_modify_wrap_hidden_operations"`
`18`		`- data-testid="testing"`
`19`	`18`	`>`
`20`	`19`	`<ModularComponent content={content}/>`
`21`	`20`	`</PluginSlot>`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@ function PluginSlotWithModularPlugins() {`
`14`	`14`	`<h2 className="pl-3">Direct Plugins Using Modular Components</h2>`
`15`	`15`	`<PluginSlot`
`16`	`16`	`id="slot_with_modular_plugins"`
`17`		`- data-testid="testing"`
`18`	`17`	`>`
`19`	`18`	`<ModularComponent content={content} />`
`20`	`19`	`</PluginSlot>`