Skip to content

Commit d9d3501

Browse files
committed
Fix types in commons
1 parent 4c1e3dd commit d9d3501

File tree

3 files changed

+29
-33
lines changed

3 files changed

+29
-33
lines changed

openfisca_core/commons/misc.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from typing import TypeVar
22

3-
from openfisca_core.types import Array
3+
import numpy
44

55
T = TypeVar("T")
66

@@ -43,7 +43,7 @@ def empty_clone(original: T) -> T:
4343
return new
4444

4545

46-
def stringify_array(array: Array) -> str:
46+
def stringify_array(array: numpy.ndarray) -> str:
4747
"""Generates a clean string representation of a numpy array.
4848
4949
Args:

openfisca_core/commons/rates.py

Lines changed: 27 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
1-
from typing import Optional
1+
from typing import Optional, Sequence
22

33
import numpy
44

5-
from openfisca_core.types import ArrayLike, Array
6-
75

86
def average_rate(
9-
target: Array[float],
10-
varying: ArrayLike[float],
11-
trim: Optional[ArrayLike[float]] = None,
12-
) -> Array[float]:
7+
target: numpy.ndarray,
8+
varying: Sequence[float],
9+
trim: Optional[Sequence[float]] = None,
10+
) -> numpy.ndarray:
1311
"""Computes the average rate of a target net income.
1412
1513
Given a ``target`` net income, and according to the ``varying`` gross
@@ -41,32 +39,31 @@ def average_rate(
4139
4240
"""
4341

44-
average_rate: Array[float]
45-
46-
average_rate = 1 - target / varying
42+
rate: numpy.ndarray
43+
rate = 1 - target / varying
4744

4845
if trim is not None:
4946

50-
average_rate = numpy.where(
51-
average_rate <= max(trim),
52-
average_rate,
47+
rate = numpy.where(
48+
rate <= max(trim),
49+
rate,
5350
numpy.nan,
5451
)
5552

56-
average_rate = numpy.where(
57-
average_rate >= min(trim),
58-
average_rate,
53+
rate = numpy.where(
54+
rate >= min(trim),
55+
rate,
5956
numpy.nan,
6057
)
6158

62-
return average_rate
59+
return rate
6360

6461

6562
def marginal_rate(
66-
target: Array[float],
67-
varying: Array[float],
68-
trim: Optional[ArrayLike[float]] = None,
69-
) -> Array[float]:
63+
target: numpy.ndarray,
64+
varying: numpy.ndarray,
65+
trim: Optional[numpy.ndarray] = None,
66+
) -> numpy.ndarray:
7067
"""Computes the marginal rate of a target net income.
7168
7269
Given a ``target`` net income, and according to the ``varying`` gross
@@ -98,26 +95,26 @@ def marginal_rate(
9895
9996
"""
10097

101-
marginal_rate: Array[float]
98+
rate: numpy.ndarray
10299

103-
marginal_rate = (
100+
rate = (
104101
+ 1
105102
- (target[:-1] - target[1:])
106103
/ (varying[:-1] - varying[1:])
107104
)
108105

109106
if trim is not None:
110107

111-
marginal_rate = numpy.where(
112-
marginal_rate <= max(trim),
113-
marginal_rate,
108+
rate = numpy.where(
109+
rate <= max(trim),
110+
rate,
114111
numpy.nan,
115112
)
116113

117-
marginal_rate = numpy.where(
118-
marginal_rate >= min(trim),
119-
marginal_rate,
114+
rate = numpy.where(
115+
rate >= min(trim),
116+
rate,
120117
numpy.nan,
121118
)
122119

123-
return marginal_rate
120+
return rate

openfisca_core/tracers/computation_log.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ def display(
2727
) -> str:
2828
if isinstance(value, EnumArray):
2929
value = value.decode_to_str()
30-
raise ValueError(type(value))
3130

3231
return numpy.array2string(value, max_line_width = None)
3332

0 commit comments

Comments
 (0)