Skip to content

Commit 7614d93

Browse files
authored
.h simplification (#7442)
#changelog #core
1 parent fed7f34 commit 7614d93

File tree

6 files changed

+19
-33
lines changed

6 files changed

+19
-33
lines changed

libs/openFrameworks/math/ofMath.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#include "ofMath.h"
2-
#include "ofUtils.h"
32
#include "ofNoise.h"
43
#include "ofPolyline.h"
54
#include <float.h>

libs/openFrameworks/types/ofBaseTypes.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#include "ofUtils.h"
21
#include "ofGLUtils.h"
32
#include "ofGLProgrammableRenderer.h"
43
#include "of3dGraphics.h"

libs/openFrameworks/utils/ofFileUtils.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
#include "ofFileUtils.h"
2+
#include "ofLog.h"
3+
24
#ifndef TARGET_WIN32
35
#include <pwd.h>
46
#include <sys/stat.h>
57
#include <unistd.h>
68
#endif
79

8-
#include "ofUtils.h"
9-
#include "ofLog.h"
10-
11-
1210
#ifdef TARGET_OSX
1311
#include <mach-o/dyld.h> /* _NSGetExecutablePath */
1412
#include <limits.h> /* PATH_MAX */

libs/openFrameworks/utils/ofSystemUtils.cpp

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,11 @@
33
#include "ofFileUtils.h"
44
#include "ofLog.h"
55
#include "ofUtils.h"
6+
#include "ofConstants.h"
7+
68
#include <condition_variable>
79
#include <mutex>
810

9-
#ifdef TARGET_WIN32
10-
#include <winuser.h>
11-
#include <commdlg.h>
12-
#define _WIN32_DCOM
13-
14-
#include <windows.h>
15-
#include <shlobj.h>
16-
#include <tchar.h>
17-
#include <stdio.h>
18-
19-
20-
#endif
21-
2211
#ifdef TARGET_OSX
2312
// ofSystemUtils.cpp is configured to build as
2413
// objective-c++ so as able to use Cocoa dialog panels
@@ -31,6 +20,14 @@
3120
#endif
3221

3322
#ifdef TARGET_WIN32
23+
24+
#define _WIN32_DCOM
25+
#include <winuser.h>
26+
#include <commdlg.h>
27+
#include <windows.h>
28+
#include <shlobj.h>
29+
#include <tchar.h>
30+
#include <stdio.h>
3431
#include <locale>
3532
#include <sstream>
3633
#include <string>

libs/openFrameworks/utils/ofSystemUtils.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include "ofConstants.h"
3+
#include <string>
44

55
/// \class ofFileDialogResult
66
/// \brief file dialog box selection or save result

libs/openFrameworks/utils/ofUtils.cpp

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "ofUtils.h"
2+
// FIXME: split ofUtils in two files, one which uses urlparser / ofImage, other without for smaller apps.
23
#include "ofImage.h"
34
#include "ofLog.h"
45
#include "ofAppBaseWindow.h"
@@ -15,17 +16,17 @@
1516

1617
#ifdef TARGET_WIN32 // For ofLaunchBrowser.
1718
#include <shellapi.h>
18-
#endif
19-
20-
21-
#ifdef TARGET_WIN32
2219
#ifndef _MSC_VER
2320
#include <unistd.h> // this if for MINGW / _getcwd
2421
#include <sys/param.h> // for MAXPATHLEN
22+
// FIXME: else
2523
#endif
24+
#ifdef _MSC_VER
25+
#include <direct.h>
26+
#endif
27+
#include <mmsystem.h>
2628
#endif
2729

28-
2930
#if defined(TARGET_OF_IOS) || defined(TARGET_OSX ) || defined(TARGET_LINUX) || defined(TARGET_EMSCRIPTEN)
3031
#include <sys/time.h>
3132
#endif
@@ -39,14 +40,6 @@
3940
#include <mach/mach.h>
4041
#endif
4142

42-
#ifdef TARGET_WIN32
43-
#include <mmsystem.h>
44-
#ifdef _MSC_VER
45-
#include <direct.h>
46-
#endif
47-
48-
#endif
49-
5043
#ifdef TARGET_OF_IOS
5144
#include "ofxiOSExtras.h"
5245
#endif

0 commit comments

Comments
 (0)