Skip to content

Commit 88338f9

Browse files
committed
πŸ›(eucalyptus/3/wb) avoid build error when running npm install
When running npm install on `edx-ui-toolkit`, npm tries to run a command git ls-remote -h -t git://github.com/bessdsv/bower-installer.git It seems that github does not accept this syntax anymore because it still works with `ssh://[email protected]`. Since it's not trivial to control what git command npm issues, we avoided this problem by installing only the specific packet we need.
1 parent 82f8c40 commit 88338f9

File tree

5 files changed

+26
-10
lines changed

5 files changed

+26
-10
lines changed

β€Ž.circleci/config.ymlβ€Ž

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -158,11 +158,13 @@ jobs:
158158
#
159159
# Note that the job name should match the EDX_RELEASE value
160160

161-
# Run jobs for the dogwood.3-fun release
162-
dogwood.3-fun:
161+
# No changes detected for dogwood.3-fun
162+
# Run jobs for the eucalyptus.3-bare release
163+
eucalyptus.3-bare:
164+
<<: [*defaults, *build_steps]
165+
# Run jobs for the eucalyptus.3-wb release
166+
eucalyptus.3-wb:
163167
<<: [*defaults, *build_steps]
164-
# No changes detected for eucalyptus.3-bare
165-
# No changes detected for eucalyptus.3-wb
166168
# No changes detected for hawthorn.1-bare
167169
# No changes detected for hawthorn.1-oee
168170
# No changes detected for ironwood.2-bare
@@ -257,15 +259,21 @@ workflows:
257259

258260
# Build jobs
259261

260-
# Run jobs for the dogwood.3-fun release
261-
- dogwood.3-fun:
262+
# No changes detected so no job to run for dogwood.3-fun
263+
# Run jobs for the eucalyptus.3-bare release
264+
- eucalyptus.3-bare:
265+
requires:
266+
- check-configuration
267+
filters:
268+
tags:
269+
ignore: /.*/
270+
# Run jobs for the eucalyptus.3-wb release
271+
- eucalyptus.3-wb:
262272
requires:
263273
- check-configuration
264274
filters:
265275
tags:
266276
ignore: /.*/
267-
# No changes detected so no job to run for eucalyptus.3-bare
268-
# No changes detected so no job to run for eucalyptus.3-wb
269277
# No changes detected so no job to run for hawthorn.1-bare
270278
# No changes detected so no job to run for hawthorn.1-oee
271279
# No changes detected so no job to run for ironwood.2-bare

β€Žreleases/eucalyptus/3/bare/CHANGELOG.mdβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ release.
1313

1414
- Use Nginx Inc's unprivileged image instead of our custom image for OpenShift
1515

16+
### Fixed
17+
18+
- Avoid build error when running npm install on `edx-ui-toolkit` due to github command
19+
1620
## [eucalyptus.3-1.2.1] - 2021-08-28
1721

1822
### Fixed

β€Žreleases/eucalyptus/3/bare/Dockerfileβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ RUN npm install
150150
# Force the reinstallation of edx-ui-toolkit's dependencies inside its
151151
# node_modules because someone is poking files from there when updating assets.
152152
RUN cd node_modules/edx-ui-toolkit && \
153-
npm install
153+
npm install backbone.paginator
154154

155155
# Update assets skipping collectstatic (it should be done during deployment)
156156
RUN NO_PREREQ_INSTALL=1 \

β€Žreleases/eucalyptus/3/wb/CHANGELOG.mdβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ release.
99

1010
## [Unreleased]
1111

12+
### Fixed
13+
14+
- Avoid build error when running npm install on `edx-ui-toolkit` due to github command
15+
1216
## [eucalyptus.3-wb-1.12.1] - 2022-04-14
1317

1418
### Fixed

β€Žreleases/eucalyptus/3/wb/Dockerfileβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ RUN npm install
152152
# Force the reinstallation of edx-ui-toolkit's dependencies inside its
153153
# node_modules because someone is poking files from there when updating assets.
154154
RUN cd node_modules/edx-ui-toolkit && \
155-
npm install
155+
npm install backbone.paginator
156156

157157
# Update assets skipping collectstatic (it should be done during deployment)
158158
RUN NO_PREREQ_INSTALL=1 \

0 commit comments

Comments
Β (0)