-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] ThreadPoolAdapterState related optimization #1385
Comments
我理解一下,你们现在遇到的问题是:
所以你们希望:如果要新增指标字段,最好可以不需要替换 |
由于hippo提供的适配器不太适合我们,所以ThreadPoolAdapter是我们自己实现的注入的。 |
我理解了,这样的话,是不是最好 |
好的,之后的java-agent版本会有 |
我们会尽可能的保留原有的功能,不过目前也不能完全保证不会因为代码调整导致部分功能无法兼容。 @zjHe |
Demand advice
Please answer these questions before submitting them. Thank you.
Is your function request related to the problem?
是的
Describe the function you want
目前适配器线程池的运行数据采集意义不大,目前了解到是因为有些框架线程API加了锁,会影响性能,所以没采集。
我们项目内部使用适配器线程大多是自己重写适配器来满足适配,我们可以自己植入线程池当时的运行状况数据到ThreadPoolAdapterState对象当中,但目前ThreadPoolAdapterState对象无预留字段,如果我们要达到目的,需要更改client的ThreadPoolAdapterState增加参数、填充参数数据,并且在AdapterThreadPoolMicrometerMonitorHandler实现上,把数据上报,对客户端重新打包。
是否hippo可以预留这部分参数,并且在AdapterThreadPoolMicrometerMonitorHandler数据上报。这样我们只需要修改适配器注入自己的bean就可以
The text was updated successfully, but these errors were encountered: