8359437: Make users and test suite not able to set LockingMode flag

8358542: Remove RTM test VMProps

Co-authored-by: Fredrik Bredberg <[email protected]>
Reviewed-by: coleenp, lmesnik, fbredberg, alanb, dholmes

Author: 2 people

src/hotspot/share/prims/whitebox.cpp

@@ -85,6 +85,7 @@
 #include "runtime/javaCalls.hpp"
 #include "runtime/javaThread.inline.hpp"
 #include "runtime/jniHandles.inline.hpp"
+#include "runtime/lightweightSynchronizer.hpp"
 #include "runtime/lockStack.hpp"
 #include "runtime/os.hpp"
 #include "runtime/stackFrameStream.inline.hpp"

src/hotspot/share/runtime/arguments.cpp

@@ -1836,15 +1836,6 @@ bool Arguments::check_vm_args_consistency() {
   }
 #endif
 
-#ifndef _LP64
-  if (LockingMode == LM_LEGACY) {
-    FLAG_SET_CMDLINE(LockingMode, LM_LIGHTWEIGHT);
-    // Self-forwarding in bit 3 of the mark-word conflicts
-    // with 4-byte-aligned stack-locks.
-    warning("Legacy locking not supported on this platform");
-  }
-#endif
-
   if (UseObjectMonitorTable && LockingMode != LM_LIGHTWEIGHT) {
     // ObjectMonitorTable requires lightweight locking.
     FLAG_SET_CMDLINE(UseObjectMonitorTable, false);
@@ -3770,9 +3761,6 @@ void Arguments::set_compact_headers_flags() {
       FLAG_SET_DEFAULT(UseObjectMonitorTable, true);
     }
   }
-  if (UseCompactObjectHeaders && LockingMode != LM_LIGHTWEIGHT) {
-    FLAG_SET_DEFAULT(LockingMode, LM_LIGHTWEIGHT);
-  }
   if (UseCompactObjectHeaders && !UseCompressedClassPointers) {
     FLAG_SET_DEFAULT(UseCompressedClassPointers, true);
   }

src/hotspot/share/runtime/globals.hpp

@@ -1957,13 +1957,6 @@ const int ObjectAlignmentInBytes = 8;
              "Mark all threads after a safepoint, and clear on a modify "   \
              "fence. Add cleanliness checks.")                              \
                                                                             \
-  product(int, LockingMode, LM_LIGHTWEIGHT,                                 \
-          "(Deprecated) Select locking mode: "                              \
-          "0: (Deprecated) monitors only (LM_MONITOR), "                    \
-          "1: (Deprecated) monitors & legacy stack-locking (LM_LEGACY), "   \
-          "2: monitors & new lightweight locking (LM_LIGHTWEIGHT, default)") \
-          range(0, 2)                                                       \
-                                                                            \
   product(bool, UseObjectMonitorTable, false, DIAGNOSTIC,                   \
           "With Lightweight Locking mode, use a table to record inflated "  \
           "monitors rather than the first word of the object.")             \

src/hotspot/share/utilities/globalDefinitions.cpp

@@ -56,6 +56,8 @@ int LogMinObjAlignmentInBytes  = -1;
 // Oop encoding heap max
 uint64_t OopEncodingHeapMax = 0;
 
+const int LockingMode = LM_LIGHTWEIGHT;
+
 // Something to help porters sleep at night
 
 #ifdef ASSERT

src/hotspot/share/utilities/globalDefinitions.hpp

@@ -1009,6 +1009,8 @@ enum LockingMode {
   LM_LIGHTWEIGHT = 2
 };
 
+extern const int LockingMode;
+
 //----------------------------------------------------------------------------------------------------
 // Special constants for debugging
 

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/LockingMode.java

@@ -222,29 +222,18 @@ private JavaThread owningThreadFromMonitor(Address o) {
 
     public JavaThread owningThreadFromMonitor(ObjectMonitor monitor) {
         if (monitor.isOwnedAnonymous()) {
-            if (VM.getVM().getCommandLineFlag("LockingMode").getInt() == LockingMode.getLightweight()) {
-                OopHandle object = monitor.object();
-                for (int i = 0; i < getNumberOfThreads(); i++) {
-                    JavaThread thread = getJavaThreadAt(i);
-                    if (thread.isLockOwned(object)) {
-                        return thread;
-                     }
-                }
-                // We should have found the owner, however, as the VM could be in any state, including the middle
-                // of performing GC, it is not always possible to do so. Just return null if we can't locate it.
-                System.out.println("Warning: We failed to find a thread that owns an anonymous lock. This is likely");
-                System.out.println("due to the JVM currently running a GC. Locking information may not be accurate.");
-                return null;
-            } else {
-                assert(VM.getVM().getCommandLineFlag("LockingMode").getInt() == LockingMode.getLegacy());
-                Address o = (Address)monitor.stackLocker();
-                for (int i = 0; i < getNumberOfThreads(); i++) {
-                    JavaThread thread = getJavaThreadAt(i);
-                    if (thread.isLockOwned(o))
-                        return thread;
-                }
-                return null;
+            OopHandle object = monitor.object();
+            for (int i = 0; i < getNumberOfThreads(); i++) {
+                JavaThread thread = getJavaThreadAt(i);
+                if (thread.isLockOwned(object)) {
+                    return thread;
+                 }
             }
+            // We should have found the owner, however, as the VM could be in any state, including the middle
+            // of performing GC, it is not always possible to do so. Just return null if we can't locate it.
+            System.out.println("Warning: We failed to find a thread that owns an anonymous lock. This is likely");
+            System.out.println("due to the JVM currently running a GC. Locking information may not be accurate.");
+            return null;
         } else {
             return owningThreadFromMonitor(monitor.owner());
         }

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/Threads.java

@@ -37,7 +37,6 @@ serviceability/sa/ClhsdbPstack.java#core                8346719 generic-all
 gtest/GTestWrapper.java                                 8356201 generic-all
 gtest/LargePageGtests.java#use-large-pages              8356201 generic-all
 gtest/LargePageGtests.java#use-large-pages-1G           8356201 generic-all
-gtest/LockStackGtests.java                              8356201 generic-all
 gtest/MetaspaceGtests.java#no-ccs                       8356201 generic-all
 gtest/NMTGtests.java#nmt-detail                         8356201 generic-all
 gtest/NMTGtests.java#nmt-off                            8356201 generic-all

test/hotspot/jtreg/ProblemList-StaticJdk.txt

@@ -142,7 +142,6 @@ tier1_common = \
   sources \
   sanity/BasicVMTest.java \
   gtest/GTestWrapper.java \
-  gtest/LockStackGtests.java \
   gtest/MetaspaceGtests.java \
   gtest/LargePageGtests.java \
   gtest/NMTGtests.java \

test/hotspot/jtreg/TEST.groups

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -26,9 +26,6 @@
  * @bug 8337660
  * @summary Test that C2 does not remove blocks with BoxLock nodes that are
  *          otherwise empty.
- * @run main/othervm -Xbatch -XX:LockingMode=1
- *                   -XX:CompileOnly=compiler.locks.TestSynchronizeWithEmptyBlock::*
- *                   compiler.locks.TestSynchronizeWithEmptyBlock
  * @run main/othervm -Xbatch
  *                   -XX:CompileOnly=compiler.locks.TestSynchronizeWithEmptyBlock::*
  *                   compiler.locks.TestSynchronizeWithEmptyBlock

test/hotspot/jtreg/compiler/locks/TestSynchronizeWithEmptyBlock.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2023, 2025, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -24,6 +24,7 @@
 import jdk.test.lib.process.OutputAnalyzer;
 import jdk.test.lib.Platform;
 import jdk.test.lib.process.ProcessTools;
+import jdk.test.whitebox.WhiteBox;
 
 import java.lang.management.ManagementFactory;
 import java.lang.management.ThreadInfo;
@@ -34,10 +35,13 @@
  * @bug 8318757
  * @summary Test concurrent monitor deflation by MonitorDeflationThread and thread dumping
  * @library /test/lib
- * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:GuaranteedAsyncDeflationInterval=2000 -XX:LockingMode=0 ConcurrentDeflation
+ * @build jdk.test.whitebox.WhiteBox
+ * @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox
+ * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions -XX:GuaranteedAsyncDeflationInterval=2000 -XX:+WhiteBoxAPI ConcurrentDeflation
  */
 
 public class ConcurrentDeflation {
+    static final WhiteBox WB = WhiteBox.getWhiteBox();
     public static final long TOTAL_RUN_TIME_NS = 10_000_000_000L;
     public static Object[] monitors = new Object[1000];
     public static int monitorCount;
@@ -73,6 +77,12 @@ static private void createMonitors() {
             index = index++ % 1000;
             monitors[index] = new Object();
             synchronized (monitors[index]) {
+                try {
+                    // Force inflation
+                    monitors[index].wait(1);
+                } catch (InterruptedException e) {
+                    throw new RuntimeException(e);
+                }
                 monitorCount++;
             }
         }