Skip to content

Conversation

@wb-zjp846396
Copy link

@wb-zjp846396 wb-zjp846396 commented Nov 27, 2025

JBS: https://bugs.openjdk.org/browse/JDK-8372651

Summary:

  • Fix a constant-condition if statement in AreaOp.java line 160.
  • Clean up dead code and clarify control flow.

Testing:

  • No functional modification involved.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28528/head:pull/28528
$ git checkout pull/28528

Update a local copy of the PR:
$ git checkout pull/28528
$ git pull https://git.openjdk.org/jdk.git pull/28528/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28528

View PR using the GUI difftool:
$ git pr show -t 28528

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28528.diff

../jdk/src/java.desktop/share/classes/sun/awt/geom/AreaOp.java:160:Do
not use if statements that are always true or always false.

Signed-off-by: Jiapeng Chong <[email protected]>
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 27, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2025

Hi @wb-zjp846396, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user wb-zjp846396" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

⚠️ @wb-zjp846396 a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 848c0c79b69c489db6c6bbb24644134fe33fd0ec
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

openjdk bot commented Nov 27, 2025

@wb-zjp846396 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@wb-zjp846396
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Nov 27, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client [email protected] oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

1 participant