Skip to content

8309953: Strengthen and optimize oopDesc age methods #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgithubli
Copy link

@rgithubli rgithubli commented Jul 8, 2025

https://bugs.openjdk.org/browse/JDK-8309953

A clean backport. An minor optimization for oopDesc age.

tier 1 passed locally. The logic is simple - store the mark() value into a var so we don't read it twice. The original commit is in tip for almost 2 years. Low risk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8309953 needs maintainer approval

Issue

  • JDK-8309953: Strengthen and optimize oopDesc age methods (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1950/head:pull/1950
$ git checkout pull/1950

Update a local copy of the PR:
$ git checkout pull/1950
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1950/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1950

View PR using the GUI difftool:
$ git pr show -t 1950

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1950.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4a5475ce0492fc02019b0f89b50601c388c63e21 8309953: Strengthen and optimize oopDesc age methods Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

⚠️ @rgithubli This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2025

Webrevs

@rgithubli
Copy link
Author

/approval request for backport of 4a5475ce0492fc02019b0f89b50601c388c63e21.

Minor gc perf improvement when it's on a hot path: See the benchmark in comment: openjdk/jdk#14456 (comment)

The backport applies cleanly. Tested with tier 1. In mainline for 2 years. The risk is low.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@rgithubli
8309953: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant