8353698: Output of Simple Web Server is garbled if the console's encoding is not UTF-8

[kurashige23]

Hi,

This is a backport of JDK-8353698: Output of Simple Web Server is garbled if the console's encoding is not UTF-8

Original patch applies cleanly to 21u.
This PR depends on #1980. So #1980 shoud be integrated first.

Testing: test/jdk/com/sun/net/httpserver/simpleserver passes on Japanese Windows and English Windows.

Thanks.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8353698 needs maintainer approval

Integration blocker

 ⚠️ Dependency #1980 must be integrated first

Issue

• JDK-8353698: Output of Simple Web Server is garbled if the console's encoding is not UTF-8 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1981/head:pull/1981
$ git checkout pull/1981

Update a local copy of the PR:
$ git checkout pull/1981
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1981/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1981

View PR using the GUI difftool:
$ git pr show -t 1981

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1981.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into pr/1980 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (9974c4e9)

[kurashige23]

/approval request Backporting this patch eliminates the problem that output of Simple Web Server is garbled if the console's encoding is not UTF-8.
This backport includes bug fix and test fix.
Risk is low: affect encoding of Simple Web Server output and fix tests
test/jdk/com/sun/net/httpserver/simpleserver passes on Japanese Windows and English Windows.
Clean backport.

[openjdk]

@kurashige23
8353698: The approval request has been created successfully.

[GoeLin]

Hi @kurashige23
I tried to run this through our testing. It does not apply though.
The patch to test/jdk/com/sun/net/httpserver/simpleserver/jwebserver/IPv6BoundHost.java
is the problem. Could you please merge head?

[kurashige23]

Hi @GoeLin

This PR has dependent PR #1980, so I created this PR against pr/1980 branch according to "What to do with changes depending on each other?" in https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix .

IPv6BoundHost.java was added in #1980.
I think #1980 shoud be integrated first.

Sorry for forgetting refering to dependent fix in Fix Request.

Thanks.

[kurashige23]

/approval request Backporting this patch eliminates the problem that output of Simple Web Server is garbled if the console's encoding is not UTF-8.
This backport includes bug fix and test fix and depends on JDK-8332020.
Risk is low: affect encoding of Simple Web Server output and fix tests
test/jdk/com/sun/net/httpserver/simpleserver passes on Japanese Windows and English Windows.
Clean backport.

[openjdk]

@kurashige23
8353698: The approval request has been updated successfully.

[GoeLin]

Hi @kurashige23
ah, I missed that. Ok, thanks.