8339280: jarsigner -verify performs cross-checking between CEN and LOC

[franferrax]

Hi, this is a backport of openjdk/jdk11u-dev#3098. The backport isn't clean, because of the following:

• File paths that require adjustment for 8u
• In Main.java, trivial context differences and code that needs adjustment from 11u to 8u:
  • java.nio.file.Path.of() ⟶ java.nio.file.Paths.get()
  • InputStream::transferTo(OutputStream.nullOutputStream()) ⟶ original code before a review suggestion
• In the test (VerifyJarEntryName.java), code that needs adjustment from 11u to 8u:
  • @library /test/lib ⟶ @library /lib/testlibrary
  • JUnit 5 ⟶ JUnit 4
    • org.junit.jupiter.api.BeforeAll ⟶ org.junit.BeforeClass
    • org.junit.jupiter.api.BeforeEach ⟶ org.junit.Before
    • org.junit.jupiter.api.Test ⟶ org.junit.Test
    • java.nio.file.Path.of() ⟶ java.nio.file.Paths.get()
    • @BeforeClass, @Before and @Test methods must be public
  • Can't use var
  • Arrays.equals(a, start, end, b, 0, b.length) ⟶ Arrays.equals(Arrays.copyOfRange(a, start, end), b) (Arrays::equals with offsets not present in 8u)
• NOTE: for the Japanese manpages translation approach, please refer to 8339280: jarsigner -verify performs cross-checking between CEN and LOC jdk11u-dev#3098
  • I updated jdk/src/linux/doc/man/ja/jarsigner.1 and jdk/src/solaris/doc/sun/man/man1/ja/jarsigner.1 (identical), and left dk/src/bsd/doc/man/ja/jarsigner.1 untouched (doesn't have any content besides the headers)
  • $\mbox{\color{red}UPDATE}$ (28348b2): all the internationalized messages have been removed, as they aren't typically included in backports (thanks @jerboaa for letting me know).

Related issues ("relates to" Jira issue links)

JDK-8353299 (openjdk/jdk@acd4da4) and JDK-8367782 (openjdk/jdk@1b9a116) were also included as part of this backport. They are test-only changes that improve the reliability and coverage of VerifyJarEntryName.java.

Since test/hotspot/jtreg/runtime/appcds/SignedJar.java is not present in 8u, JDK-8353330 was not included.

Testing

• Besides the tier1 run from the GitHub actions (similar results as the current master run), I ran a regression using the following categories and individual tests:
  • jdk/test/com/sun/jarsigner
  • jdk/test/java/security/SignedJar
  • jdk/test/java/util/jar
  • jdk/test/sun/security/pkcs/pkcs7
  • jdk/test/sun/security/tools/jarsigner
    • Includes VerifyJarEntryName.java, created for this issue
  • jdk/test/sun/security/tools/keytool

No regressions were found against the current master branch (9a4bc2d).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8339280 needs maintainer approval
• JDK-8353299 needs maintainer approval
• JDK-8367782 needs maintainer approval

Issues

• JDK-8339280: jarsigner -verify performs cross-checking between CEN and LOC (Enhancement - P4)
• JDK-8353299: VerifyJarEntryName.java test fails (Bug - P3)
• JDK-8367782: VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName (Bug - P4)

Reviewers

• Alexey Bakhtin (@alexeybakhtin - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/699/head:pull/699
$ git checkout pull/699

Update a local copy of the PR:
$ git checkout pull/699
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/699/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 699

View PR using the GUI difftool:
$ git pr show -t 699

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/699.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fferrari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[franferrax]

/issue add 8353299

[franferrax]

/issue add 8367782

[mlbridge]

Webrevs

• 01: Full - Incremental (28348b29)
• 00: Full (d1c0f3ef)

[openjdk]

@franferrax
Adding additional issue to issue list: 8353299: VerifyJarEntryName.java test fails.

[openjdk]

@franferrax
Adding additional issue to issue list: 8367782: VerifyJarEntryName.java: Fix modifyJarEntryName to operate on bytes and re-introduce verifySignatureEntryName.

[alexeybakhtin]

LGTM
CI failures look unrelated
All related jarsigner tests passed