You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+14-14
Original file line number
Diff line number
Diff line change
@@ -6,7 +6,7 @@ OpenJFX is an open source project and we love to receive contributions from our
6
6
Bug reports
7
7
-----------
8
8
9
-
If you think you have found a bug in OpenJFX, first make sure that you are testing against the latest version - your issue may already have been fixed. If not, search our [issues list](https://bugs.openjdk.java.net/issues/?filter=39543) in the Java Bug System (JBS) in case a similar issue has already been opened. More information on where and how to report a bug can be found at [bugreport.java.com](https://bugreport.java.com/).
9
+
If you think you have found a bug in OpenJFX, first make sure that you are testing against the latest version - your issue may already have been fixed. If not, search our [issues list](https://bugs.openjdk.org/issues/?filter=39543) in the Java Bug System (JBS) in case a similar issue has already been opened. More information on where and how to report a bug can be found at [bugreport.java.com](https://bugreport.java.com/).
10
10
11
11
It is very helpful if you can prepare a reproduction of the bug. In other words, provide a small test case which we can run to confirm your bug. It makes it easier to find the problem and to fix it.
12
12
@@ -16,13 +16,13 @@ Feature requests
16
16
----------------
17
17
18
18
If you find yourself wishing for a feature that doesn't exist in OpenJFX, you are probably not alone. There are bound to be others out there with similar needs. Many of the features that OpenJFX has today have been added because our users saw the need. Please be aware that
19
-
all new feature requests, including any API changes, need prior discussion on the [openjfx-dev](https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev) mailing list, even if there is already an open
20
-
[JBS issue](https://bugs.openjdk.java.net). See the [New features / API additions](#new-features--api-additions) section below for more information.
19
+
all new feature requests, including any API changes, need prior discussion on the [openjfx-dev](https://mail.openjdk.org/mailman/listinfo/openjfx-dev) mailing list, even if there is already an open
20
+
[JBS issue](https://bugs.openjdk.org). See the [New features / API additions](#new-features--api-additions) section below for more information.
21
21
22
22
Contributing code and documentation changes
23
23
-------------------------------------------
24
24
25
-
If you have a bug fix or new feature that you would like to contribute to OpenJFX, please talk about what you would like to do on the [openjfx-dev](https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev) mailing list. It may be that somebody is already working on it, or that there are particular issues that you should know about before implementing the change.
25
+
If you have a bug fix or new feature that you would like to contribute to OpenJFX, please talk about what you would like to do on the [openjfx-dev](https://mail.openjdk.org/mailman/listinfo/openjfx-dev) mailing list. It may be that somebody is already working on it, or that there are particular issues that you should know about before implementing the change.
26
26
27
27
We enjoy working with contributors to get their code accepted. There are many approaches to fixing a problem and it is important to find the best approach before writing too much code.
28
28
@@ -46,11 +46,11 @@ If you are a first time contributor to OpenJFX, welcome! Please do the following
46
46
47
47
* Read the code review policies
48
48
49
-
Please read the entire section below on how to submit a pull request, as well as the [OpenJFX Code Review Policies](https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews). If this is a feature request, please note the additional requirements and expectations in the [New features / API additions](#new-features--api-additions) section at the end of this guide.
49
+
Please read the entire section below on how to submit a pull request, as well as the [OpenJFX Code Review Policies](https://wiki.openjdk.org/display/OpenJFX/Code+Reviews). If this is a feature request, please note the additional requirements and expectations in the [New features / API additions](#new-features--api-additions) section at the end of this guide.
50
50
51
51
* File a bug in JBS for every pull request
52
52
53
-
A unique [JBS](https://bugs.openjdk.java.net) bug ID is needed for every
53
+
A unique [JBS](https://bugs.openjdk.org) bug ID is needed for every
54
54
pull request. If there isn't already a bug filed in JBS, then please
55
55
file one at [bugreport.java.com](https://bugreport.java.com/).
56
56
A developer with an active OpenJDK ID can file a bug directly in JBS.
@@ -88,7 +88,7 @@ Once your changes and tests are ready to submit for review:
88
88
The Skara bot will then run `jcheck` on the server to verify the format
89
89
of the PR title and check for whitespace errors. Once that passes,
90
90
it will automatically send a Request For Review (RFR) email to the
It is the responsibility of the Reviewer(s) and the Committer who
120
120
will integrate or sponsor the change to ensure that the code review policies
121
121
are followed, and that all concerns have been addressed.
@@ -144,7 +144,7 @@ Once your changes and tests are ready to submit for review:
144
144
Reviewer role in the project.
145
145
146
146
NOTE: A reviewer can indicate that a PR needs a
147
-
[CSR](https://wiki.openjdk.java.net/display/csr/Main) by
147
+
[CSR](https://wiki.openjdk.org/display/csr/Main) by
148
148
entering the `/csr` command. The Skara bot will then require an approved
149
149
CSR before the PR can be integrated.
150
150
@@ -178,7 +178,7 @@ The main idea is to think in terms of "stewardship" when evolving the JavaFX API
178
178
It begins before you submit a pull request for review, and continues after the new feature is integrated.
179
179
With that in mind, here are the needed steps to get a new feature into JavaFX.
180
180
181
-
1. Discuss the proposed feature on the [openjfx-dev](https://mail.openjdk.java.net/mailman/listinfo/openjfx-dev) mailing list.
181
+
1. Discuss the proposed feature on the [openjfx-dev](https://mail.openjdk.org/mailman/listinfo/openjfx-dev) mailing list.
182
182
You should start with _why_ you think
183
183
adding the API to the core of JavaFX is a good and useful addition for multiple applications (not just your own)
184
184
and for the evolution of the JavaFX UI Toolkit. Part of this is to see whether the Project Leads and Reviewers
@@ -191,16 +191,16 @@ proceed to the API.
191
191
192
192
2. Discuss the API needed to provide the feature. While this can't always be completely separated from its
193
193
implementation, it is the public API itself that is important to nail down and get right. While we don't currently
194
-
use the formal JEP process as is done for larger JDK features, the [JEP template](http://openjdk.java.net/jeps/2)
194
+
use the formal JEP process as is done for larger JDK features, the [JEP template](https://openjdk.org/jeps/2)
195
195
provides some ideas to consider when proposing an API, such as a summary of the changes, goals, motivation, testing,
196
196
dependencies, etc. A Draft (or WIP) pull request can be useful for illustrative purposes as long as the focus is on the public API.
197
197
If there are trade-offs to be made in the implementation, or different implementation approaches that you might take,
198
198
this is a good time to discuss it. Once this step is far enough along that there is general agreement as to the API,
199
199
then it's time to focus on the implementation.
200
200
201
201
3. Submit a review of your proposed implementation. As noted in the
202
-
[New features / API additions](https://wiki.openjdk.java.net/display/OpenJFX/Code+Reviews#CodeReviews-NewFeaturesC.Newfeatures/APIadditions.)
203
-
section of the Code Review Policies doc, we also need a [CSR](https://wiki.openjdk.java.net/display/csr/Main), which documents the API change and its approval.
202
+
[New features / API additions](https://wiki.openjdk.org/display/OpenJFX/Code+Reviews#CodeReviews-NewFeaturesC.Newfeatures/APIadditions.)
203
+
section of the Code Review Policies doc, we also need a [CSR](https://wiki.openjdk.org/display/csr/Main), which documents the API change and its approval.
204
204
The CSR can be reviewed in parallel. Changes in the API that arise during the review need to be reflected in the CSR, meaning
205
205
that the final review / approval of the CSR usually happens late in the review cycle.
206
206
You can avoid extra work by waiting to submit the CSR until the API is agreed upon and the code review for the documentation is reasonably far along.
@@ -254,4 +254,4 @@ bash ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true all test
254
254
If you don't build WebKit (using the `-PCOMPILE_WEBKIT=true` option), you are likely to get test failures when running the web tests. See the [Web Testing](WEBKIT-MEDIA-STUBS.md) page for information on how to address this.
255
255
256
256
Even more documentation on OpenJFX projects and its build system can be found on the
Copy file name to clipboardExpand all lines: README.md
+3-3
Original file line number
Diff line number
Diff line change
@@ -4,15 +4,15 @@ OpenJFX is an open source, next generation client application platform for deskt
4
4
5
5
OpenJFX is free software, licensed under [GPL v2 with the Classpath exception](LICENSE), just like the JDK. Anybody is welcome to contribute to this project, port it to other platforms or devices, or do anything else that a free software license allows you to do!
6
6
7
-
OpenJFX is a project under the charter of the OpenJDK. The [OpenJDK Bylaws](https://openjdk.java.net/bylaws) and [License](LICENSE) govern our work. The OpenJFX project membership can be found on the [OpenJDK Census](https://openjdk.java.net/census#openjfx). We welcome patches and involvement from individual contributors or companies. If this is your first time contributing to an OpenJDK project, you will need to review the rules on [becoming a Contributor](https://openjdk.java.net/bylaws#contributor), and sign the [Oracle Contributor Agreement](https://oca.opensource.oracle.com/) (OCA).
7
+
OpenJFX is a project under the charter of the OpenJDK. The [OpenJDK Bylaws](https://openjdk.org/bylaws) and [License](LICENSE) govern our work. The OpenJFX project membership can be found on the [OpenJDK Census](https://openjdk.org/census#openjfx). We welcome patches and involvement from individual contributors or companies. If this is your first time contributing to an OpenJDK project, you will need to review the rules on [becoming a Contributor](https://openjdk.org/bylaws#contributor), and sign the [Oracle Contributor Agreement](https://oca.opensource.oracle.com/) (OCA).
8
8
9
9
## Issue tracking
10
10
11
-
If you think you have found a bug in OpenJFX, first make sure that you are testing against the latest version - your issue may already have been fixed. If not, search our [issues list](https://bugs.openjdk.java.net/issues/?filter=39543) in the Java Bug System (JBS) in case a similar issue has already been opened. More information on where and how to report a bug can be found at [bugreport.java.com](https://bugreport.java.com/).
11
+
If you think you have found a bug in OpenJFX, first make sure that you are testing against the latest version - your issue may already have been fixed. If not, search our [issues list](https://bugs.openjdk.org/issues/?filter=39543) in the Java Bug System (JBS) in case a similar issue has already been opened. More information on where and how to report a bug can be found at [bugreport.java.com](https://bugreport.java.com/).
12
12
13
13
## Getting Started
14
14
15
-
For instructions on building JavaFX, see the [Building OpenJFX](https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX) Wiki page.
15
+
For instructions on building JavaFX, see the [Building OpenJFX](https://wiki.openjdk.org/display/OpenJFX/Building+OpenJFX) Wiki page.
16
16
17
17
For information about downloading and using JavaFX, see the [JavaFX community site](https://openjfx.io/).
0 commit comments