Skip to content

7904104: intermittent test failure in TimeoutDefaultSecondsWaiter #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vpa1977 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

7904104: intermittent test failure in TimeoutDefaultSecondsWaiter #296

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afdfb42
fix: do not interrupt the main thread
vpa1977 Oct 27, 2025
cdec2a0
fix: interrupt the main thread if the process fails to exit
vpa1977 Oct 28, 2025
f893ba6
chore: remove whitespace
vpa1977 Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/share/classes/com/sun/javatest/regtest/exec/ProcessCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,17 @@ public void run() {

timeoutHandlerDone.countDown();

// JDK 1.8 introduces a Process.waitFor(timeout) method which could
// be used here. We need run on 1.5 so using interrupt() instead.
victim.interrupt();
// unlock the main thread if the process fails
// to exit
try {
if (!process.waitFor(timeout, TimeUnit.SECONDS)) {
victim.interrupt();
}
}
catch (InterruptedException e) {
log.println("Interrupted exception: " + e);
victim.interrupt();
}
}
};
timeoutHandlerThread.setName("Timeout Handler for " + cmd.get(0));
Expand Down