feat: add config flag support for deploy, preview, and upload commands #790
+34
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ea348db The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vicb
reviewed
Jul 15, 2025
| @@ -96,11 +96,14 @@ export function getCacheAssets(opts: BuildOptions): CacheAsset[] { | |||
|
|
|||
| async function populateR2IncrementalCache( | |||
| options: BuildOptions, | |||
| populateCacheOptions: { target: WranglerTarget; environment?: string } | |||
| populateCacheOptions: { target: WranglerTarget; environment?: string; config?: string } | |||
There was a problem hiding this comment.
Could you please extract the type to top level?
(Maybe add a comment here that the cacheChunkSize is not used)
vicb
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
LGTM, thanks a lot for the PR 🙏
@james-elicx Could you please take a look when you have time
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #761 .
Old: #762