Skip to content

Commit e351a81

Browse files
committed
Merge remote-tracking branch 'origin/main' into release
2 parents fd29582 + 2b66535 commit e351a81

File tree

12 files changed

+21
-17
lines changed

12 files changed

+21
-17
lines changed

CHANGELOG.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ on each modality instead of on the whole `MuData` object.
3030

3131
* `interactive/run_cellxgene`: Updated container to ubuntu:focal because it contains python3.6 but cellxgene dropped python3.6 support.
3232

33-
* `download/download_file`: Switch base container from `ubuntu:22.04` to `bash:5.1` because `ubuntu:22.04`
34-
was causing some edge case issues.
35-
3633
* `mapping/bd_rhapsody_wta`: Set `--parallel` to true by default.
3734

3835
* `mapping/bd_rhapsody_wta`: Translate Bash script into Python.
@@ -47,6 +44,10 @@ on each modality instead of on the whole `MuData` object.
4744

4845
* Various `config.vsh.yaml`s: Renamed `values:` to `choices:`.
4946

47+
* `download/download_file` and `transfer/publish`: Switch base container from `bash:5.1` to `python:3.10`.
48+
49+
* `mapping/bd_rhapsody_wta`: Make sure procps is installed.
50+
5051
## BUG FIXES
5152

5253
* `mapping/bd_rhapsody_wta`: Use a smaller test dataset to reduce test time and make sure that the Github Action runners do not run out of disk space.

bin/build_release.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ bin/viash_build -m release -t $TAG
2626
# run unit tests (when done right, these should all pass)
2727
bin/viash_test -m release -t $TAG
2828

29+
# rebuild readme
30+
quarto render README.qmd
31+
2932
# push docker containers to docker hub
3033
bin/viash_push -m release -t $TAG
3134

src/download/download_file/config.vsh.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ functionality:
3737
path: run_test.sh
3838
platforms:
3939
- type: docker
40-
image: "bash:5.1"
41-
setup:
42-
- type: apk
43-
packages: [ wget ]
40+
image: "python:3.10"
4441
- type: nextflow
4542
variant: vdsl3

src/mapping/bd_rhapsody_wta/config.vsh.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ platforms:
118118
- type: docker
119119
run: apt-get --allow-releaseinfo-change update
120120
- type: apt
121-
packages: cwltool
121+
packages: [ cwltool, procps ]
122122
- type: nextflow
123123
variant: vdsl3
124124
directives:

src/mapping/bd_rhapsody_wta_1_10/config.novsh.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ platforms:
132132
image: bdgenomics/rhapsody:1.10
133133
setup:
134134
- type: apt
135-
packages: cwltool
135+
packages: [ cwltool, procps ]
136136
- type: nextflow
137137
variant: vdsl3
138138
directives:

src/mapping/bd_rhapsody_wta_1_10_1/config.novsh.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ platforms:
132132
image: bdgenomics/rhapsody:1.10.1
133133
setup:
134134
- type: apt
135-
packages: cwltool
135+
packages: [ cwltool, procps ]
136136
- type: nextflow
137137
variant: vdsl3
138138
directives:

src/transfer/publish/config.vsh.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ functionality:
2727
path: run_test.sh
2828
platforms:
2929
- type: docker
30-
image: bash:5.1
30+
image: python:3.10
3131
- type: nextflow
3232
variant: vdsl3

workflows/1_ingestion/bd_rhapsody_wta/main.nf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ workflow run_wf {
148148
| groupTuple()
149149

150150
// Step 4: convert to h5ad
151-
| map { id, input -> [ id, input, params ]}
151+
| map { id, input -> [ id, [input: input ], params ]}
152152
| view { "converting_to_h5ad: [$it]" }
153153
| from_bdrhap_to_h5ad
154154

workflows/1_ingestion/bd_rhapsody_wta/test/integration_test.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ bin/nextflow \
1313
-main-script workflows/1_ingestion/bd_rhapsody_wta/main.nf \
1414
-entry test_wf \
1515
-resume \
16-
-with-docker
16+
-with-docker \
17+
-with-trace work/trace.txt
1718

1819
# -c workflows/1_ingestion/bd_rhapsody_wta/nextflow.config \
1920

workflows/1_ingestion/cellranger_demux/test/integration_test.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,5 @@ bin/nextflow \
1313
-main-script workflows/1_ingestion/cellranger_demux/main.nf \
1414
-entry test_wf \
1515
-resume \
16-
-with-docker
16+
-with-docker \
17+
-with-trace work/trace.txt

0 commit comments

Comments
 (0)