-
-
Notifications
You must be signed in to change notification settings - Fork 3
async feature added
#27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix issues in decorators
* Async bugs: call the play function async from test script * Test script: more intuitive example of test script
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #27 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 56 77 +21
Branches 4 6 +2
=========================================
+ Hits 56 77 +21
☔ View full report in Codecov by Sentry. |
|
As we discussed with @sepandhaghighi, this approach is not well-suited for the higher-end user. We want something like this: playsound('test.wav', is_async=True)and no extra function definition nor using The best approach, I believe, is to use |
|
Yeah, I agree. It's better we hide the internal mechanisms of the library from high-end users. |
|
Closed by opening #28 |
Reference Issues/PRs
#5
As @NimaSamadi007 said:
My solution for this part is to define a new function
play_asyncso two parts are completely separated. What do you think @sepandhaghighi ?And thanks for your efforts @NimaSamadi007