Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for switching between two servers #252

Open
enchained opened this issue Jan 30, 2025 · 4 comments
Open

Improvements for switching between two servers #252

enchained opened this issue Jan 30, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@enchained
Copy link

Looks like switching between two servers keeps the scroll position you had (focused on the Nth entry), which is very confusing, since you are losing the position you had before the tab switch, go to some random position in another list, do your business there, and then find yourself in a random place when you return. Similar things happen with filters like labels, trackers, directories - sometime it's useful, but most of the time the list turns out empty because there is no such label/directory/tracker on another server. You also have to reset the search every time you switch, and set the search again if you want to continue.

I think sometimes keeping the same filters across multiple servers can be useful, especially if you have servers with similar data and a batch workflow for them. But for other times filters mostly come in the way of browsing and make the list empty and you have to remember that you had filters on before you switched the server.

I have a few suggestions on how to fix this:

  • Reset filters on switch, but only in obvious cases when there is no such filter on the other server (directories, trackers, labels, etc.). Scroll position should probably be reset too. Not sure about the search filter, since having no search results might be a meaningful thing too.

  • Add some additional indication of applied filters, since those might be out of view (like trackers) or the user might not expect filters transfer to another server and just think something is wrong with the list itself since it's just empty. The most common filter indication would be having an overlay for the empty torrent list saying "no results for "search term/directory/tracker/status/label filter name" with a button to reset. Another indication would be having closable labels inside the search bar mentioning active filters like tracker or directory etc., joined by OR or AND, depending on how multiselect mode works (I think now it is AND, but OR might be useful in some cases I guess, with some toggle in the GUI).

  • Make option(s?) in the settings to keep the filters, scroll position, search and other useful state separately for each server.

@qu1ck
Copy link
Member

qu1ck commented Feb 2, 2025

Good points and suggestions.
After thinking about it some I think adding these 2 things will cover the main issues:

  1. Reset filter to default if the server does not same label/directory/tracker filter
  2. Show amount of filtered torrents prominently in the table somewhere so that it's obvious that filters are active.

I don't think adding more settings for keeping per server UI state is better, I'm trying to keep amount of settings to a minimum for maintainability and UI simplicity.
Having more complex filter query with configurable AND/OR joins is also an overkill IMO. You can achieve most of that with some crafty label application.

@qu1ck qu1ck added the enhancement New feature or request label Feb 3, 2025
@enchained
Copy link
Author

adding these 2 things will cover the main issues:

  1. Reset filter to default if the server does not same label/directory/tracker filter
  2. Show amount of filtered torrents prominently in the table somewhere so that it's obvious that filters are active.

Thanks, I think those will do nicely. Does (1) also include resetting the scroll position?

@qu1ck
Copy link
Member

qu1ck commented Feb 6, 2025

No, that's part of UI state.

@smopucilowski
Copy link

It would be nice if server tabs were hot-keyable. On mac it would be nice to ⌘+1, ⌘+2, etc to change tabs as it works across all other applications, as well as have server tabs enumerated in the window toolbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants