chen - add a todo for using name group API once we fully support JDK 20+

RyanL1997 · RyanL1997 · commit bf77fe25db58 · 2025-10-28T16:23:02.000-07:00
Signed-off-by: Jialiang Liang &lt;jiallian@amazon.com&gt;
diff --git a/core/src/main/java/org/opensearch/sql/calcite/CalciteRelNodeVisitor.java b/core/src/main/java/org/opensearch/sql/calcite/CalciteRelNodeVisitor.java
@@ -282,6 +282,9 @@ public RelNode visitRex(Rex node, CalcitePlanContext context) {
           "Rex pattern must contain at least one named capture group");
     }
 
+    // TODO: Once JDK 20+ is supported, consider using Pattern.namedGroups() API for more efficient
+    // named group handling instead of manual parsing in RegexCommonUtils
+
     List<RexNode> newFields = new ArrayList<>();
     List<String> newFieldNames = new ArrayList<>();
 

Original file line number	Diff line number	Diff line change
`@@ -282,6 +282,9 @@ public RelNode visitRex(Rex node, CalcitePlanContext context) {`
`282`	`282`	`"Rex pattern must contain at least one named capture group");`
`283`	`283`	`}`
`284`	`284`
	`285`	`+ // TODO: Once JDK 20+ is supported, consider using Pattern.namedGroups() API for more efficient`
	`286`	`+ // named group handling instead of manual parsing in RegexCommonUtils`
	`287`	`+`
`285`	`288`	`List<RexNode> newFields = new ArrayList<>();`
`286`	`289`	`List<String> newFieldNames = new ArrayList<>();`
`287`	`290`