Skip to content

Commit e9938e1

Browse files
committed
Disable network segmentation when multus is disabled
Signed-off-by: Riccardo Ravaioli <[email protected]>
1 parent 29122af commit e9938e1

File tree

2 files changed

+45
-0
lines changed

2 files changed

+45
-0
lines changed

pkg/network/ovn_kubernetes.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,8 @@ func renderOVNKubernetes(conf *operv1.NetworkSpec, bootstrapResult *bootstrap.Bo
368368
data.Data["OVN_MULTI_NETWORK_POLICY_ENABLE"] = false
369369
if conf.DisableMultiNetwork != nil && *conf.DisableMultiNetwork {
370370
data.Data["OVN_MULTI_NETWORK_ENABLE"] = false
371+
data.Data["OVN_NETWORK_SEGMENTATION_ENABLE"] = false
372+
klog.Warningf("Forcing OVN_NETWORK_SEGMENTATION_ENABLE=false because DisableMultiNetwork=true in the operator config")
371373
} else if conf.UseMultiNetworkPolicy != nil && *conf.UseMultiNetworkPolicy {
372374
// Multi-network policy support requires multi-network support to be
373375
// enabled

pkg/network/ovn_kubernetes_test.go

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -821,6 +821,49 @@ logfile-maxage=0`,
821821
controlPlaneReplicaCount: 2,
822822
enabledFeatureGates: []configv1.FeatureGateName{apifeatures.FeatureGateNetworkSegmentation},
823823
},
824+
{
825+
desc: "disable network segmentation when multi-network is disabled",
826+
expected: `
827+
[default]
828+
mtu="1500"
829+
cluster-subnets="10.128.0.0/15/23,10.0.0.0/14/24"
830+
encap-port="8061"
831+
enable-lflow-cache=true
832+
lflow-cache-limit-kb=1048576
833+
enable-udp-aggregation=true
834+
udn-allowed-default-services="default/kubernetes,openshift-dns/dns-default"
835+
836+
[kubernetes]
837+
service-cidrs="172.30.0.0/16"
838+
ovn-config-namespace="openshift-ovn-kubernetes"
839+
apiserver="https://testing.test:8443"
840+
host-network-namespace="openshift-host-network"
841+
platform-type="GCP"
842+
healthz-bind-address="0.0.0.0:10256"
843+
dns-service-namespace="openshift-dns"
844+
dns-service-name="dns-default"
845+
846+
[ovnkubernetesfeature]
847+
enable-egress-ip=true
848+
enable-egress-firewall=true
849+
enable-egress-qos=true
850+
enable-egress-service=true
851+
egressip-node-healthcheck-port=9107
852+
enable-multi-external-gateway=true
853+
854+
[gateway]
855+
mode=shared
856+
nodeport=true
857+
858+
[logging]
859+
libovsdblogfile=/var/log/ovnkube/libovsdb.log
860+
logfile-maxsize=100
861+
logfile-maxbackups=5
862+
logfile-maxage=0`,
863+
controlPlaneReplicaCount: 2,
864+
disableMultiNet: true,
865+
enabledFeatureGates: []configv1.FeatureGateName{apifeatures.FeatureGateNetworkSegmentation},
866+
},
824867
{
825868
desc: "enable multi-network policies without multi-network support",
826869
expected: `

0 commit comments

Comments
 (0)