Skip to content

Commit b487f43

Browse files
committed
Address feedback
1 parent cd00445 commit b487f43

File tree

3 files changed

+10
-20
lines changed

3 files changed

+10
-20
lines changed

frontend/public/components/namespace.jsx

+1-6
Original file line numberDiff line numberDiff line change
@@ -764,11 +764,6 @@ export const ProjectsTable = (props) => {
764764
const headerWithMetrics = () => projectTableHeader({ showMetrics: true, showActions: true });
765765
const headerNoMetrics = () => projectTableHeader({ showMetrics: false, showActions: true });
766766

767-
const ProjectNotFoundMessage = () => {
768-
const { t } = useTranslation();
769-
return <OpenShiftGettingStarted title={t('public~Welcome to OpenShift')} />;
770-
};
771-
772767
const ProjectEmptyMessage = () => {
773768
const { t } = useTranslation();
774769
return (
@@ -828,7 +823,7 @@ export const ProjectList = ({ data, ...tableProps }) => {
828823
data={data}
829824
Header={showMetrics ? headerWithMetrics : headerNoMetrics}
830825
Row={ProjectTableRow}
831-
NoDataEmptyMsg={ProjectNotFoundMessage}
826+
NoDataEmptyMsg={OpenShiftGettingStarted}
832827
EmptyMsg={ProjectEmptyMessage}
833828
customData={customData}
834829
virtualize

frontend/public/components/start-guide.tsx

+6-10
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ import { K8sResourceKind } from '../module/k8s/types';
1313
import { useCreateNamespaceOrProjectModal } from '@console/shared/src/hooks/useCreateNamespaceOrProjectModal';
1414
import { RootState } from '../redux';
1515
import { useFlag } from '@console/shared/src';
16-
import { ExternalLinkAltIcon, OpenshiftIcon } from '@patternfly/react-icons';
16+
import { ClusterIcon, ExternalLinkAltIcon } from '@patternfly/react-icons';
1717

18-
export const OpenShiftGettingStarted: React.FCC<OpenShiftGettingStartedProps> = ({ title }) => {
18+
export const OpenShiftGettingStarted: React.FCC<OpenShiftGettingStartedProps> = () => {
1919
const { t } = useTranslation();
2020
const [, setActiveNamespace] = useActiveNamespace();
2121
const [perspective] = useActivePerspective();
@@ -67,21 +67,17 @@ export const OpenShiftGettingStarted: React.FCC<OpenShiftGettingStartedProps> =
6767
return (
6868
<ConsoleEmptyState
6969
variant={EmptyStateVariant.xl}
70-
icon={OpenshiftIcon}
71-
title={title || t('public~Getting started in OpenShift')}
70+
icon={ClusterIcon}
71+
title={t('public~Hello, world!')}
7272
primaryActions={primaryActions}
7373
secondaryActions={secondaryActions}
7474
>
7575
{canCreate ? (
76-
<p>
77-
{t(
78-
'public~OpenShift helps you quickly develop, host, and scale applications. To get started, create a project for your application.',
79-
)}
80-
</p>
76+
<p>{t('public~To get started, create a project for your application.')}</p>
8177
) : (
8278
<p>
8379
{t(
84-
"public~OpenShift helps you quickly develop, host, and scale applications. To get started, you'll need a project. Currently, you can't create or access any projects.",
80+
"public~To get started, you'll need a project. Currently, you can't create or access any projects.",
8581
)}
8682
{!createProjectMessage &&
8783
t("public~ You'll need to contact a cluster administrator for help.")}

frontend/public/locales/en/public.json

+3-4
Original file line numberDiff line numberDiff line change
@@ -1077,7 +1077,6 @@
10771077
"No results match the filter criteria.": "No results match the filter criteria.",
10781078
"Namespaces": "Namespaces",
10791079
"Projects": "Projects",
1080-
"Welcome to OpenShift": "Welcome to OpenShift",
10811080
"No matching Projects": "No matching Projects",
10821081
"by name or display name": "by name or display name",
10831082
"Project": "Project",
@@ -1410,9 +1409,9 @@
14101409
"Snippets": "Snippets",
14111410
"Create a new Project": "Create a new Project",
14121411
"Download command-line tools": "Download command-line tools",
1413-
"Getting started in OpenShift": "Getting started in OpenShift",
1414-
"OpenShift helps you quickly develop, host, and scale applications. To get started, create a project for your application.": "OpenShift helps you quickly develop, host, and scale applications. To get started, create a project for your application.",
1415-
"OpenShift helps you quickly develop, host, and scale applications. To get started, you'll need a project. Currently, you can't create or access any projects.": "OpenShift helps you quickly develop, host, and scale applications. To get started, you'll need a project. Currently, you can't create or access any projects.",
1412+
"Hello, world!": "Hello, world!",
1413+
"To get started, create a project for your application.": "To get started, create a project for your application.",
1414+
"To get started, you'll need a project. Currently, you can't create or access any projects.": "To get started, you'll need a project. Currently, you can't create or access any projects.",
14161415
" You'll need to contact a cluster administrator for help.": " You'll need to contact a cluster administrator for help.",
14171416
"StatefulSet details": "StatefulSet details",
14181417
"StatefulSets": "StatefulSets",

0 commit comments

Comments
 (0)