Skip to content

Commit e0ae6ac

Browse files
committed
OCPBUGS-56255: OCPBUGS-56077: remove 60 day alert from cluster update modal
1 parent 75bc164 commit e0ae6ac

File tree

3 files changed

+9
-40
lines changed

3 files changed

+9
-40
lines changed

frontend/public/components/modals/cluster-update-modal.tsx

Lines changed: 7 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,10 @@ import * as React from 'react';
33
import { useTranslation } from 'react-i18next';
44
import { Alert, Radio, Text, TextContent, TextVariants } from '@patternfly/react-core';
55
import { useK8sWatchResource } from '@console/internal/components/utils/k8s-watch-hook';
6-
import {
7-
documentationURLs,
8-
ExternalLink,
9-
getDocumentationURL,
10-
} from '@console/internal/components/utils';
116
import { DropdownWithSwitch } from '@console/shared/src/components/dropdown';
127

138
import { ClusterVersionModel, MachineConfigPoolModel, NodeModel } from '../../models';
14-
import {
15-
FieldLevelHelp,
16-
HandlePromiseProps,
17-
LinkifyExternal,
18-
isManaged,
19-
withHandlePromise,
20-
} from '../utils';
9+
import { FieldLevelHelp, HandlePromiseProps, LinkifyExternal, withHandlePromise } from '../utils';
2110
import {
2211
ClusterVersionKind,
2312
getConditionUpgradeableFalse,
@@ -189,7 +178,6 @@ const ClusterUpdateModal = withHandlePromise((props: ClusterUpdateModalProps) =>
189178
label: t('public~Have known issues'),
190179
});
191180
}
192-
const helpURL = getDocumentationURL(documentationURLs.updateUsingCustomMachineConfigPools);
193181

194182
return (
195183
<form onSubmit={submit} name="form" className="modal-content" data-test="update-cluster-modal">
@@ -255,7 +243,7 @@ const ClusterUpdateModal = withHandlePromise((props: ClusterUpdateModalProps) =>
255243
{t('public~Update options')}
256244
<FieldLevelHelp>
257245
{t(
258-
"public~Full cluster update allows you to update all your Nodes, but takes longer. Control plane only update allows you to pause worker and custom pool Nodes to accommodate your maintenance schedule, but you'll need to resume the non-control plane Node updates within 60 days to avoid failure.",
246+
'public~Full cluster update allows you to update all your Nodes, but takes longer. Control plane only update allows you to pause worker and custom pool Nodes to accommodate your maintenance schedule.',
259247
)}
260248
</FieldLevelHelp>
261249
</label>
@@ -307,24 +295,11 @@ const ClusterUpdateModal = withHandlePromise((props: ClusterUpdateModalProps) =>
307295
className="pf-v5-u-mb-md"
308296
body={
309297
upgradeType === upgradeTypes.Partial && (
310-
<>
311-
<MachineConfigPoolsSelector
312-
machineConfigPools={pauseableMCPs}
313-
selected={machineConfigPoolsToPause}
314-
onChange={handleMCPSelectionChange}
315-
/>
316-
<Alert
317-
variant="warning"
318-
isInline
319-
isPlain
320-
title={t('public~You must resume updates within 60 days to avoid failures.')}
321-
className="pf-v5-u-mb-md"
322-
>
323-
{!isManaged() && (
324-
<ExternalLink href={helpURL}>{t('public~Learn more')}</ExternalLink>
325-
)}
326-
</Alert>
327-
</>
298+
<MachineConfigPoolsSelector
299+
machineConfigPools={pauseableMCPs}
300+
selected={machineConfigPoolsToPause}
301+
onChange={handleMCPSelectionChange}
302+
/>
328303
)
329304
}
330305
data-test="update-cluster-modal-partial-update-radio"

frontend/public/components/utils/documentation.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,6 @@ export const documentationURLs: documentationURLsType = {
6161
'html/updating_clusters/performing-a-cluster-update#updating-a-cluster-in-a-disconnected-environment',
6262
upstream: '', // intentionally blank as there is no upstream equivalent
6363
},
64-
updateUsingCustomMachineConfigPools: {
65-
downstream:
66-
'html/updating_clusters/performing-a-cluster-update#update-using-custom-machine-config-pools',
67-
upstream: 'updating/updating_a_cluster/update-using-custom-machine-config-pools.html',
68-
},
6964
usingInsights: {
7065
downstream:
7166
'html/support/remote-health-monitoring-with-connected-clusters#using-insights-to-identify-issues-with-your-cluster',

frontend/public/locales/en/public.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -831,14 +831,12 @@
831831
"These versions are supported, but include known issues. Review the known issues before updating.": "These versions are supported, but include known issues. Review the known issues before updating.",
832832
"Updating this cluster to {{desiredVersion}} is supported, but includes known issues. Review the known issues before updating.": "Updating this cluster to {{desiredVersion}} is supported, but includes known issues. Review the known issues before updating.",
833833
"Update options": "Update options",
834-
"Full cluster update allows you to update all your Nodes, but takes longer. Control plane only update allows you to pause worker and custom pool Nodes to accommodate your maintenance schedule, but you'll need to resume the non-control plane Node updates within 60 days to avoid failure.": "Full cluster update allows you to update all your Nodes, but takes longer. Control plane only update allows you to pause worker and custom pool Nodes to accommodate your maintenance schedule, but you'll need to resume the non-control plane Node updates within 60 days to avoid failure.",
834+
"Full cluster update allows you to update all your Nodes, but takes longer. Control plane only update allows you to pause worker and custom pool Nodes to accommodate your maintenance schedule.": "Full cluster update allows you to update all your Nodes, but takes longer. Control plane only update allows you to pause worker and custom pool Nodes to accommodate your maintenance schedule.",
835835
"Full cluster update": "Full cluster update",
836836
"{{master}}, {{worker}}, and custom pool {{resource}} are updated concurrently. This might take longer, so make sure to allocate enough time for maintenance.": "{{master}}, {{worker}}, and custom pool {{resource}} are updated concurrently. This might take longer, so make sure to allocate enough time for maintenance.",
837837
"Paused {{worker}} or custom pool {{resource}} updates will be resumed. If you want to update only the control plane, select \"Control plane only update\" below.": "Paused {{worker}} or custom pool {{resource}} updates will be resumed. If you want to update only the control plane, select \"Control plane only update\" below.",
838838
"Control plane only update": "Control plane only update",
839839
"Pause {{worker}} or custom pool {{resource}} updates to accommodate your maintenance schedule.": "Pause {{worker}} or custom pool {{resource}} updates to accommodate your maintenance schedule.",
840-
"You must resume updates within 60 days to avoid failures.": "You must resume updates within 60 days to avoid failures.",
841-
"Learn more": "Learn more",
842840
"Update": "Update",
843841
"Selected columns will appear in the table.": "Selected columns will appear in the table.",
844842
"You can select up to {{MAX_VIEW_COLS}} columns": "You can select up to {{MAX_VIEW_COLS}} columns",
@@ -1921,6 +1919,7 @@
19211919
"TCP socket (port)": "TCP socket (port)",
19221920
"Admission Webhook Warning": "Admission Webhook Warning",
19231921
"{{kind}} {{name}} violates policy {{warning}}": "{{kind}} {{name}} violates policy {{warning}}",
1922+
"Learn more": "Learn more",
19241923
"Are you sure you want to remove <1>{{label}}</1> from navigation?": "Are you sure you want to remove <1>{{label}}</1> from navigation?",
19251924
"Refer to your cluster administrator to know which network provider is used.": "Refer to your cluster administrator to know which network provider is used.",
19261925
"Input error: selectors must start and end by a letter or number, and can only contain -, _, / or . Offending value: {{offendingSelector}}": "Input error: selectors must start and end by a letter or number, and can only contain -, _, / or . Offending value: {{offendingSelector}}",

0 commit comments

Comments
 (0)