Skip to content

Commit 370a1bf

Browse files
committed
Add a new field Mapped into openshift-test extension Image struct
The new field Mapped contains all the same fields of Image resource that can be used later for openshift-tests images cmd to parse this Mapped key. The k8s-tests-ext will construct this Mapped key from GetMappedImageConfigs() function from upstream. Signed-off-by: Vu Dinh <[email protected]>
1 parent 1b675e1 commit 370a1bf

File tree

2 files changed

+14
-5
lines changed
  • openshift-hack/cmd/k8s-tests-ext
  • vendor/github.com/openshift-eng/openshift-tests-extension/pkg/extension

2 files changed

+14
-5
lines changed

openshift-hack/cmd/k8s-tests-ext/k8s-tests.go

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,16 @@ func main() {
8888
Qualifiers: []string{withExcludedTestsFilter(`name.contains('[Serial]')`)},
8989
})
9090

91-
for k, v := range image.GetOriginalImageConfigs() {
92-
image := convertToImage(v)
93-
image.Index = int(k)
91+
mirror := "quay.io/openshift/community-e2e-images"
92+
if v := os.Getenv("TEST_IMAGE_MIRROR"); len(v) > 0 {
93+
mirror = v
94+
}
95+
originals := image.GetOriginalImageConfigs()
96+
mapped := image.GetMappedImageConfigs(originals, mirror)
97+
for k, v := range originals {
98+
image := convertToImage(v, int(k))
99+
mappedImage := convertToImage(mapped[k], int(k))
100+
image.Mapped = &mappedImage
94101
kubeTestsExtension.RegisterImage(image)
95102
}
96103

@@ -158,10 +165,10 @@ func main() {
158165
}
159166
}
160167

161-
// convertToImages converts an image.Config to an extension.Image, which
168+
// convertToImage converts an image.Config to an extension.Image, which
162169
// can easily be serialized to JSON. Since image.Config has unexported fields,
163170
// reflection is used to read its values.
164-
func convertToImage(obj interface{}) e.Image {
171+
func convertToImage(obj interface{}, index int) e.Image {
165172
image := e.Image{}
166173
val := reflect.ValueOf(obj)
167174
typ := reflect.TypeOf(obj)
@@ -177,6 +184,7 @@ func convertToImage(obj interface{}) e.Image {
177184
image.Version = fieldValue.String()
178185
}
179186
}
187+
image.Index = index
180188
return image
181189
}
182190

vendor/github.com/openshift-eng/openshift-tests-extension/pkg/extension/types.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)