CORS-4228: GCP revert custom endpoints

[barbacbd]

While this method would work we found a simpler solution that requires no changes to this code. We have decided to create a new private zone that will be used to route traffic intended for googleapis.com to the endpoint (ip address) for the private service connect endpoint. We have seen better results with this setup too.

Revert "cloud/gcp/actuators/machine:"

This reverts commit f4bf1e20084c34b36fa95020586f82775276a162.

Revert "no-jira: Update GCP Custom Endpoints Feature Gate reference"

This reverts commit 3fb47f63ea3dce14491b3bfb207effce34957e1f.

Revert "CORS-3906: Update MAPI GCP Provider to use custom GCP endpoints"

This reverts commit 17d99d9789140cb37537a8e2edfc47c8cff388b9.

[damdo]

/retest

[damdo]

Hey @barbacbd why are we reverting this? :) TY

[openshift-ci-robot]

@barbacbd: This pull request references CORS-4228 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Revert "cloud/gcp/actuators/machine:"

This reverts commit f4bf1e2.

Revert "no-jira: Update GCP Custom Endpoints Feature Gate reference"

This reverts commit 3fb47f6.

Revert "CORS-3906: Update MAPI GCP Provider to use custom GCP endpoints"

This reverts commit 17d99d9.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

/jira-refresh

[barbacbd]

Hey @barbacbd why are we reverting this? :) TY

@damdo While this method would work we found a simpler solution that requires no changes to this code. We have decided to create a new private zone that will be used to route traffic intended for googleapis.com to the endpoint (ip address) for the private service connect endpoint. We have seen better results with this setup too.

[barbacbd]

/jira refresh

[openshift-ci-robot]

@barbacbd: This pull request references CORS-4228 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@barbacbd: This pull request references CORS-4228 which is a valid jira issue.

In response to this:

While this method would work we found a simpler solution that requires no changes to this code. We have decided to create a new private zone that will be used to route traffic intended for googleapis.com to the endpoint (ip address) for the private service connect endpoint. We have seen better results with this setup too.

Revert "cloud/gcp/actuators/machine:"

This reverts commit f4bf1e2.

Revert "no-jira: Update GCP Custom Endpoints Feature Gate reference"

This reverts commit 3fb47f6.

Revert "CORS-3906: Update MAPI GCP Provider to use custom GCP endpoints"

This reverts commit 17d99d9.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

The revert is occurring because the Openshift Installer will be creating a Private Zone where
the traffic to *.googleapis.com will go to the ip address of a private service connect endpoint.
The changes for the Openshift Installer can be found here: openshift/installer#9992.
This means that we do not need to explicitly override the api endpoints in each cluster component.

For example a proxy server log from a bastion host shows this:
1762508378.713 91253 10.0.0.5 TCP_TUNNEL/200 11968 CONNECT iamcredentials.googleapis.com:443 - HIER_DIRECT/10.1.0.100 -
1762508378.970 90258 10.0.0.5 TCP_TUNNEL/200 5988 CONNECT compute.googleapis.com:443 - HIER_DIRECT/10.1.0.100 -

We can see that the ip address for the default endpoints above is now going to 10.1.0.100 which was the
ip address of the private service connect endpoint. This achieves the same result as setting the API
Endpoint override to https://compute-.p.googleapis.com/.

[damdo]

/test regression-clusterinfra-gcp-ipi-mapi

[damdo]

API revert PR here: openshift/api#2569

[damdo]

/approve

On principle and after chatting with @barbacbd

Let's wait on the api revert PR to be approved too

/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/regression-clusterinfra-gcp-ipi-mapi	fcd3f5e	link	false	/test regression-clusterinfra-gcp-ipi-mapi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[barbacbd]

api revert is here: openshift/api#2576
Reverting the feature variables but not the feature gate yet