Skip to content

Conversation

@jcpowermac
Copy link
Contributor

This commit adds two additional jobs
to test the disk setup e2e before merging.

@jcpowermac
Copy link
Contributor Author

This commit adds two additional jobs
to test the disk setup e2e before merging.
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jcpowermac: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-config-operator-main-e2e-azure-ovn-multidisk-techpreview openshift/machine-config-operator presubmit Presubmit changed
pull-ci-openshift-machine-config-operator-main-e2e-vsphere-ovn-disk-setup-techpreview openshift/machine-config-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jcpowermac
Copy link
Contributor Author

/assign @pablintino @yuqi-zhang

@jcpowermac
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcpowermac
Copy link
Contributor Author

@yuqi-zhang @pablintino please review thanks!

@pablintino
Copy link
Contributor

@jcpowermac Hi mate, I'm on PTO, I kindly ask you to ask @isabella-janssen or @djoshy for review too :)

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally seems fine to me, just had a question

branches:
- ^main$
- ^main-
cluster: vsphere02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(question for my own understanding) I didn't know we had a vsphere02 cluster. Is there a specific reason this gets autogenerated as the default vsphere job cluster? I was under the impression that our main buildxx clusters spin up resources in the different clouds based on the profile and is itself platform agnostic

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1e04f66 into openshift:master Nov 3, 2025
15 checks passed
bnshr pushed a commit to bnshr/release that referenced this pull request Nov 12, 2025
This commit adds two additional jobs
to test the disk setup e2e before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants