-
Notifications
You must be signed in to change notification settings - Fork 2k
Add vSphere and Azure tech preview, disk setup job #70811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vSphere and Azure tech preview, disk setup job #70811
Conversation
This commit adds two additional jobs to test the disk setup e2e before merging.
9499dd5 to
da56e20
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/assign @pablintino @yuqi-zhang |
|
/pj-rehearse ack |
|
@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@yuqi-zhang @pablintino please review thanks! |
|
@jcpowermac Hi mate, I'm on PTO, I kindly ask you to ask @isabella-janssen or @djoshy for review too :) |
yuqi-zhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally seems fine to me, just had a question
| branches: | ||
| - ^main$ | ||
| - ^main- | ||
| cluster: vsphere02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(question for my own understanding) I didn't know we had a vsphere02 cluster. Is there a specific reason this gets autogenerated as the default vsphere job cluster? I was under the impression that our main buildxx clusters spin up resources in the different clouds based on the profile and is itself platform agnostic
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jcpowermac: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This commit adds two additional jobs to test the disk setup e2e before merging.
This commit adds two additional jobs
to test the disk setup e2e before merging.