Fix release notes for next RC

Author: macumber

.github/workflows/release_notes.yml

@@ -11,6 +11,10 @@ jobs:
   release-notes:
     name: Create changelog
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      issues: read
+      pull-requests: read
 
     steps:
     - uses: actions/checkout@v5
@@ -28,7 +32,7 @@ jobs:
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       run: |
-        gem install github_api
+        gem install octokit
         pip install requests
         ruby ./developer/ruby/GitHubIssueStats.rb > changelog.txt
 

developer/ruby/GitHubIssueStats.rb

@@ -1,25 +1,23 @@
-require 'github_api'
+require 'octokit'
 require 'date'
 require 'yaml'
 
 # Get the begin date, by finding the last major/minor (X.Y.0) release
 # that is at least a week old
 def get_begin_date_and_previous_tag()
   a_week_ago = Time.now - (60*60*24*7)
-
-  @github.repos.releases.list(owner: @repo_owner,
-                              repo: @repo).each_page do |page|
-    page.each do |release|
-      next if release.tag_name !~ /^v\d\.\d\.0$/
-      release_date = Time.parse(release.created_at)
-      next if release_date > a_week_ago
-      # This is perhaps unecessary since we match to a tag in vX.Y.0 format
-      # already but it doesn't hurt
-      next if release.prerelease
-      next if release.draft
-      STDERR.puts "Found previous major/minor release: #{release.tag_name}, #{release_date}"
-      return release_date, " (#{release.tag_name})"
-    end
+  repo = "#{@repo_owner}/#{@repo}"
+
+  @github.releases(repo, per_page: 100).each do |release|
+    next if release.tag_name !~ /^v\d+\.\d+\.0$/
+    release_date = release.created_at.to_time
+    next if release_date > a_week_ago
+    # This is perhaps unecessary since we match to a tag in vX.Y.0 format
+    # already but it doesn't hurt
+    next if release.prerelease
+    next if release.draft
+    STDERR.puts "Found previous major/minor release: #{release.tag_name}, #{release_date}"
+    return release_date, " (#{release.tag_name})"
   end
   STDERR.puts "Cannot find previous release, setting time to 2005"
   return Time.new(2005, 01, 01), ""
@@ -60,16 +58,18 @@ def print_issue(issue)
 
 if !ENV['GITHUB_TOKEN'].nil?
   token = ENV['GITHUB_TOKEN']
-  @github = Github.new oauth_token: token
+  @github = Octokit::Client.new(access_token: token)
 elsif File.exist?(Dir.home + '/github_config.yml')
   github_options = YAML.load_file(Dir.home + '/github_config.yml')
   token = github_options['oauth_token']
-  @github = Github.new oauth_token: token
+  @github = Octokit::Client.new(access_token: token)
 else
   STDERR.puts "Github Token not found"
-  @github = Github.new
+  @github = Octokit::Client.new
 end
 
+@github.auto_paginate = true
+
 @begin_date, @prev_tag = get_begin_date_and_previous_tag()
 
 totalOpenIssues = Array.new
@@ -78,59 +78,35 @@ def print_issue(issue)
 closedIssues = Array.new
 acceptedPullRequests = Array.new
 
+repo = "#{@repo_owner}/#{@repo}"
+
 # Process Open Issues
-results = -1
-page = 1
-while (results != 0)
-  resp = @github.issues.list user: @repo_owner, repo: @repo,
-                            :sort => 'created',
-                            :direction => 'asc',
-                            :state => 'open',
-                            :per_page => 100,
-                            :page => page
-  results = resp.length
-  resp.env[:body].each do |issue, index|
-    created = Time.parse(issue.created_at)
-    if !issue.has_key?(:pull_request)
-      totalOpenIssues << issue
-      if created >= @begin_date && created <= @end_date
-        newIssues << issue
-      end
-    else
-      totalOpenPullRequests << issue
+@github.issues(repo, sort: 'created', direction: 'asc', state: 'open', per_page: 100).each do |issue|
+  created = issue.created_at.to_time
+  if issue.pull_request.nil?
+    totalOpenIssues << issue
+    if created >= @begin_date && created <= @end_date
+      newIssues << issue
     end
+  else
+    totalOpenPullRequests << issue
   end
-
-  page = page + 1
 end
 
 # Process Closed Issues
-results = -1
-page = 1
-while (results != 0)
-  resp = @github.issues.list user: @repo_owner, repo: @repo,
-                            :sort => 'created',
-                            :direction => 'asc',
-                            :state => 'closed',
-                            :per_page => 100,
-                            :page => page
-  results = resp.length
-  resp.env[:body].each do |issue, index|
-    created = Time.parse(issue.created_at)
-    closed = Time.parse(issue.closed_at)
-    if !issue.has_key?(:pull_request)
-      if created >= @begin_date && created <= @end_date
-        newIssues << issue
-      end
-      if closed >= @begin_date && closed <= @end_date
-        closedIssues << issue
-      end
-    elsif closed >= @begin_date && closed <= @end_date
-      acceptedPullRequests << issue
+@github.issues(repo, sort: 'created', direction: 'asc', state: 'closed', per_page: 100).each do |issue|
+  created = issue.created_at.to_time
+  closed = issue.closed_at.to_time
+  if issue.pull_request.nil?
+    if created >= @begin_date && created <= @end_date
+      newIssues << issue
     end
+    if closed >= @begin_date && closed <= @end_date
+      closedIssues << issue
+    end
+  elsif closed >= @begin_date && closed <= @end_date
+    acceptedPullRequests << issue
   end
-
-  page = page + 1
 end
 
 closedIssues.sort! {|x,y| get_num(x) <=> get_num(y)}