Skip to content

Commit 926bcb5

Browse files
GTEST/UCP: Improve comments and flush receiver in test_ucp_wireup_ondemand before cleanup
1 parent a2fd796 commit 926bcb5

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

test/gtest/ucp/test_ucp_wireup.cc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2052,16 +2052,20 @@ UCS_TEST_P(test_ucp_wireup_ondemand, slow_lanes,
20522052
check_lanes_arr_value(ep_cfg_key(ep).rma_bw_lanes, ep_cfg_key(ep).num_lanes,
20532053
"rma_bw", false);
20542054

2055-
// Do RMA, then at least one slow lane lane should be initialized.
2055+
// Do RMA, then at least one slow lane should be initialized.
20562056
// NOTE: number of initialized lanes depends on HW setup and protocol
2057-
// selection logic and may change in future
2057+
// selection logic, which may be changed in future
20582058
ucs::handle<ucp_rkey_h> rkey = rbuf.rkey(sender());
20592059
req = ucp_put_nbx(ep, sbuf.ptr(), sbuf.size(), (uintptr_t)rbuf.ptr(),
20602060
rkey.get(), &params);
20612061
ASSERT_UCS_OK(request_wait(req));
20622062
check_lanes_arr_value(ep_cfg_key(ep).rma_bw_lanes,
20632063
ep_cfg_key(ep).num_lanes, "rma_bw",
20642064
/*is_valid:*/ true, /*check_all_lanes:*/ false);
2065+
2066+
// Flush receiver worker to avoid accessing destroyed rbuf from test cleanup
2067+
short_progress_loop();
2068+
flush_worker((receiver().entity());
20652069
}
20662070

20672071
UCP_INSTANTIATE_TEST_CASE(test_ucp_wireup_ondemand);

0 commit comments

Comments
 (0)