UCT/CUDA_IPC: address feedback

Author: Akshay-Venkatesh

src/uct/cuda/cuda_ipc/cuda_ipc_cache.c

@@ -339,18 +339,18 @@ static ucs_status_t uct_cuda_ipc_open_memhandle(uct_cuda_ipc_rkey_t *key,
     ucs_trace("key handle type %u", key->ph.handle_type);
 
     switch(key->ph.handle_type) {
-        case UCT_CUDA_IPC_KEY_HANDLE_TYPE_LEGACY:
-            return uct_cuda_ipc_open_memhandle_legacy(key->ph.handle.legacy,
-                                                      mapped_addr);
+    case UCT_CUDA_IPC_KEY_HANDLE_TYPE_LEGACY:
+        return uct_cuda_ipc_open_memhandle_legacy(key->ph.handle.legacy,
+                                                  mapped_addr);
 #if HAVE_CUDA_FABRIC
-        case UCT_CUDA_IPC_KEY_HANDLE_TYPE_VMM:
-            return uct_cuda_ipc_open_memhandle_vmm(key, mapped_addr);
-        case UCT_CUDA_IPC_KEY_HANDLE_TYPE_MEMPOOL:
-            return uct_cuda_ipc_open_memhandle_mempool(key, mapped_addr);
+    case UCT_CUDA_IPC_KEY_HANDLE_TYPE_VMM:
+        return uct_cuda_ipc_open_memhandle_vmm(key, mapped_addr);
+    case UCT_CUDA_IPC_KEY_HANDLE_TYPE_MEMPOOL:
+        return uct_cuda_ipc_open_memhandle_mempool(key, mapped_addr);
 #endif
-        default:
-            ucs_error("unsupported key handle type");
-            return UCS_ERR_INVALID_PARAM;
+    default:
+        ucs_error("unsupported key handle type");
+        return UCS_ERR_INVALID_PARAM;
     }
 }
 

src/uct/cuda/cuda_ipc/cuda_ipc_md.c

@@ -126,8 +126,6 @@ uct_cuda_ipc_mem_add_reg(void *addr, uct_cuda_ipc_memh_t *memh,
         return UCS_ERR_NO_MEMORY;
     }
 
-    key->ph.handle_type = UCT_CUDA_IPC_KEY_HANDLE_TYPE_ERROR;
-
     UCT_CUDADRV_FUNC_LOG_ERR(cuMemGetAddressRange(&key->d_bptr, &key->b_len,
                 (CUdeviceptr)addr));
 

src/uct/cuda/cuda_ipc/cuda_ipc_md.h

@@ -17,8 +17,10 @@
 typedef enum uct_cuda_ipc_key_handle {
     UCT_CUDA_IPC_KEY_HANDLE_TYPE_ERROR = 0,
     UCT_CUDA_IPC_KEY_HANDLE_TYPE_LEGACY, /* cudaMalloc memory */
+#if HAVE_CUDA_FABRIC
     UCT_CUDA_IPC_KEY_HANDLE_TYPE_VMM, /* cuMemCreate memory */
     UCT_CUDA_IPC_KEY_HANDLE_TYPE_MEMPOOL /* cudaMallocAsync memory */
+#endif
 } uct_cuda_ipc_key_handle_t;