- 
                Notifications
    You must be signed in to change notification settings 
- Fork 832
Bug Fixes for PTQ and ACQ based OpenVINO Model Export and Added Test Cases #2594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            srikesh-07
  wants to merge
  42
  commits into
  open-edge-platform:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
srikesh-07:acq
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            42 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      b0fc113
              
                Added helper functions for loading Metrics
              
              
                srikesh-07 97e9fa2
              
                Added AnomalibMetric as subclass argument
              
              
                srikesh-07 9c744eb
              
                Modified `model.export` to dynamically load metrics
              
              
                srikesh-07 7f7cf8b
              
                Modified ACQ method to support `AnomalibMetric` method
              
              
                srikesh-07 05ab70d
              
                Update test_cli.py
              
              
                srikesh-07 8faa2c6
              
                Modified docstring and added cache clearance after test
              
              
                srikesh-07 c08eb45
              
                Removed  modified `convert_snake_to_pascal_case` as its no longer used.
              
              
                srikesh-07 cad5731
              
                Updated docstring for `get_available_metrics()`
              
              
                srikesh-07 9a0c7cd
              
                Fixed circular import and added lazy import
              
              
                srikesh-07 7cbf7e0
              
                Modifed the field name for ACQ export
              
              
                srikesh-07 a02aa37
              
                Improved code quality
              
              
                srikesh-07 87dde1c
              
                Improved code quality
              
              
                srikesh-07 5d2a3bc
              
                Removed debugging statement
              
              
                srikesh-07 7888e12
              
                Minor bug fix
              
              
                srikesh-07 3bf7af8
              
                Update __init__.py
              
              
                srikesh-07 1fbf2fb
              
                Update __init__.py
              
              
                srikesh-07 1f4948d
              
                Reformatted the code
              
              
                srikesh-07 af8c734
              
                Reformatted cli.py
              
              
                srikesh-07 2233dbd
              
                Reformatted engine.py
              
              
                srikesh-07 96860c7
              
                Reformatted export_mixin.py
              
              
                srikesh-07 d8235c8
              
                Update export_mixin.py
              
              
                srikesh-07 42fc4d5
              
                Added testcase for PTQ export
              
              
                srikesh-07 e55b6ca
              
                Update test_cli.py docstrings
              
              
                srikesh-07 177baaf
              
                Fixed typo in docstring
              
              
                srikesh-07 e0c8cc5
              
                Added testcase for FP16 and INT8 export
              
              
                srikesh-07 ad3ac99
              
                Reformatted test_cli.py
              
              
                srikesh-07 65a58ad
              
                Added `use_placeholder_fields` to `get_metric` method
              
              
                srikesh-07 c9f971c
              
                Modified 'export' method
              
              
                srikesh-07 835bf32
              
                Add configuration options to PostProcessor (#2547)
              
              
                djdameln 2dc5a19
              
                Added functionality to modify metric fields only if placeholder is usβ¦
              
              
                srikesh-07 0bb9fd8
              
                Added Unit Tests for helper functions of Metrics
              
              
                srikesh-07 01c6c05
              
                Modified Engine Export Docstrings
              
              
                srikesh-07 7d27a29
              
                Rename PostProcessor (#2589)
              
              
                djdameln 9293bd7
              
                Rename MVTec dataset to MVTecAD dataset (#2557)
              
              
                samet-akcay a30744e
              
                Update test_cli.py
              
              
                srikesh-07 9dae140
              
                Added test case and changed MVTec to MVTecAD
              
              
                srikesh-07 0737ddc
              
                Fixed a bug in calculating the metric for Binary labels
              
              
                srikesh-07 1425059
              
                Reformatted the test_cli.py
              
              
                srikesh-07 8a6ec1f
              
                Merge branch 'main' into acq
              
              
                srikesh-07 2ced95b
              
                Merge branch 'main' into acq
              
              
                samet-akcay 10020b5
              
                Fixed snake-case issue for single-word metrics
              
              
                srikesh-07 2b06dd4
              
                Merge pull request #4 from openvinotoolkit/main
              
              
                srikesh-07 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean without a placeholder?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Iβm trying to convey is this:
Letβs say the user passes a metric via the CLI using
--metrics f1_scorebut does not specify any field parameters (i.e.,--metrics.fieldsis not provided). In this case,F1Scoreis instantiated with a placeholder ([""]) in themodel.exportmethod. Later, the metricβs fields are updated based on the model type inexport_mixin.py.I also noticed a couple of grammatical mistakes in an inline comment and a logger statement:
In L367:
Change "if Metric is initialized with placeholder" to if Metric was initialized with a placeholder."
In L370:
Modify the logger statement from:
I hope this clarifies your question. Let me know if you have any further doubtsβIβd be happy to help!
Thank you.