Fix bad merge

Author: Avaneesh-axiom

examples/ecc/src/main.rs

@@ -38,16 +38,16 @@ pub fn main() {
     #[allow(clippy::op_ref)]
     let _p3 = &p1 + &p2;
 
-    let x1 = Ed25519Coord::from_be_bytes(&hex!(
+    let x1 = Ed25519Coord::from_be_bytes_unchecked(&hex!(
         "216936D3CD6E53FEC0A4E231FDD6DC5C692CC7609525A7B2C9562D608F25D51A"
     ));
-    let y1 = Ed25519Coord::from_be_bytes(&hex!(
+    let y1 = Ed25519Coord::from_be_bytes_unchecked(&hex!(
         "6666666666666666666666666666666666666666666666666666666666666658"
     ));
     let p1 = Ed25519Point::from_xy(x1, y1).unwrap();
 
     let x2 = Ed25519Coord::from_u32(2);
-    let y2 = Ed25519Coord::from_be_bytes(&hex!(
+    let y2 = Ed25519Coord::from_be_bytes_unchecked(&hex!(
         "1A43BF127BDDC4D71FF910403C11DDB5BA2BCDD2815393924657EF111E712631"
     ));
     let p2 = Ed25519Point::from_xy(x2, y2).unwrap();

extensions/ecc/tests/programs/Cargo.toml

@@ -83,18 +83,6 @@ required-features = ["k256"]
 name = "sec1_decode"
 required-features = ["k256"]
 
-[[example]]
-name = "ecdsa_recover_p256"
-required-features = ["p256"]
-
-[[example]]
-name = "ecdsa_recover_k256"
-required-features = ["k256"]
-
-[[example]]
-name = "sec1_decode"
-required-features = ["k256"]
-
 [[example]]
 name = "edwards_ec"
 required-features = ["ed25519"]

extensions/ecc/tests/programs/examples/decompress.rs

@@ -75,8 +75,8 @@ pub fn main() {
     test_impossible_sw_decompression::<CurvePoint1mod4>(&Fp1mod4::from_u8(1), rec_id);
 
     // ed25519
-    let x = Ed25519Coord::from_le_bytes(&bytes[192..224]);
-    let y = Ed25519Coord::from_le_bytes(&bytes[224..256]);
+    let x = Ed25519Coord::from_le_bytes_unchecked(&bytes[192..224]);
+    let y = Ed25519Coord::from_le_bytes_unchecked(&bytes[224..256]);
     let rec_id = x.as_le_bytes()[0] & 1;
     test_possible_te_decompression::<Ed25519Point>(&x, &y, rec_id);
     // y = 2 is not on the y-coordinate of any point on the Ed25519 curve

extensions/ecc/tests/programs/examples/edwards_ec.rs

@@ -27,24 +27,24 @@ pub fn main() {
 
     // random point on edwards25519
     let x2 = Ed25519Coord::from_u32(2);
-    let y2 = Ed25519Coord::from_be_bytes(&hex!(
+    let y2 = Ed25519Coord::from_be_bytes_unchecked(&hex!(
         "1A43BF127BDDC4D71FF910403C11DDB5BA2BCDD2815393924657EF111E712631"
     ));
     let mut p2 = Ed25519Point::from_xy(x2, y2).unwrap();
 
     // This is the sum of (x1, y1) and (x2, y2).
-    let x3 = Ed25519Coord::from_be_bytes(&hex!(
+    let x3 = Ed25519Coord::from_be_bytes_unchecked(&hex!(
         "636C0B519B2C5B1E0D3BFD213F45AFD5DAEE3CECC9B68CF88615101BC78329E6"
     ));
-    let y3 = Ed25519Coord::from_be_bytes(&hex!(
+    let y3 = Ed25519Coord::from_be_bytes_unchecked(&hex!(
         "704D8868CB335A7B609D04B9CD619511675691A78861F1DFF7A5EBC389C7EA92"
     ));
 
     // This is 2 * (x1, y1)
-    let x4 = Ed25519Coord::from_be_bytes(&hex!(
+    let x4 = Ed25519Coord::from_be_bytes_unchecked(&hex!(
         "56B98CC045559AD2BBC45CAB58D842ECEE264DB9395F6014B772501B62BB7EE8"
     ));
-    let y4 = Ed25519Coord::from_be_bytes(&hex!(
+    let y4 = Ed25519Coord::from_be_bytes_unchecked(&hex!(
         "1BCA918096D89C83A15105DF343DC9F7510494407750226DAC0A7620ACE77BEB"
     ));
 

extensions/ecc/tests/src/lib.rs

@@ -14,8 +14,7 @@ mod tests {
         utils::{air_test, air_test_with_min_segments},
     };
     use openvm_ecc_circuit::{
-        CurveConfig, EccExtension, Rv32EccConfig, SwCurveCoeffs, ED25519_CONFIG, P256_CONFIG,
-        SECP256K1_CONFIG,
+        CurveConfig, Rv32EccConfig, SwCurveCoeffs, ED25519_CONFIG, P256_CONFIG, SECP256K1_CONFIG,
     };
     use openvm_ecc_transpiler::EccTranspilerExtension;
     use openvm_rv32im_transpiler::{