Fix python script

Author: manh9203

ci/scripts/metric_unify/prometheus_flamegraph.py renamed to ci/scripts/metric_unify/flamegraph_prom.py

@@ -5,8 +5,9 @@
 import subprocess
 from prometheus_api_client import PrometheusConnect
 from utils import FLAMEGRAPHS_DIR, get_git_root
+from flamegraph import get_function_symbol
 
-def get_stack_lines(prom, group_by_kvs, stack_keys, metric_name, sum_metrics=None):
+def get_stack_lines(prom, group_by_kvs, stack_keys, metric_name, sum_metrics=None, string_table=None):
     """
     Filters metrics from prometheus for entries that look like:
         [ { labels: [["key1", "span1;span2"], ["key2", "span3"]], "metric": metric_name, "value": 2 } ]
@@ -43,7 +44,15 @@ def get_stack_lines(prom, group_by_kvs, stack_keys, metric_name, sum_metrics=Non
             if key not in labels:
                 filter = True
                 break
-            stack_values.append(labels[key])
+            if key == 'cycle_tracker_span':
+                if labels[key] == '' or string_table is None:
+                    stack_values.append(labels[key])
+                else:
+                    symbol_offsets = labels[key].split(';')
+                    function_symbols = [get_function_symbol(string_table, offset) for offset in symbol_offsets]
+                    stack_values.extend(function_symbols)
+            else:
+                stack_values.append(labels[key])
         if filter:
             continue
 
@@ -60,8 +69,8 @@ def get_stack_lines(prom, group_by_kvs, stack_keys, metric_name, sum_metrics=Non
     return lines if non_zero else []
 
 
-def create_flamegraph(fname, prom, group_by_kvs, stack_keys, metric_name, sum_metrics=None, reverse=False):
-    lines = get_stack_lines(prom, group_by_kvs, stack_keys, metric_name, sum_metrics)
+def create_flamegraph(fname, prom, group_by_kvs, stack_keys, metric_name, sum_metrics=None, reverse=False, string_table=None):
+    lines = get_stack_lines(prom, group_by_kvs, stack_keys, metric_name, sum_metrics, string_table)
     if not lines:
         return
 
@@ -88,24 +97,24 @@ def create_flamegraph(fname, prom, group_by_kvs, stack_keys, metric_name, sum_me
         print(f"Created flamegraph at {flamegraph_path}")
 
 
-def create_flamegraphs(prom, group_by, stack_keys, metric_name, sum_metrics=None, reverse=False):
+def create_flamegraphs(prom, group_by, stack_keys, metric_name, sum_metrics=None, reverse=False, string_table=None):
     # Assume group_by is a list of length 1
     group_by_values_list = prom.get_label_values(label_name=group_by[0])
     for group_by_values in group_by_values_list:
         group_by_kvs = list(zip(group_by, [group_by_values]))
         fname = 'metrics' + '-' + '-'.join([group_by_values])
-        create_flamegraph(fname, prom, group_by_kvs, stack_keys, metric_name, sum_metrics, reverse=reverse)
+        create_flamegraph(fname, prom, group_by_kvs, stack_keys, metric_name, sum_metrics, reverse=reverse, string_table=string_table)
 
 
-def create_custom_flamegraphs(prom, group_by=["group"]):
+def create_custom_flamegraphs(prom, group_by=["group"], string_table=None):
     for reverse in [False, True]:
         create_flamegraphs(prom, group_by, ["cycle_tracker_span", "dsl_ir", "opcode"], "frequency",
-                           reverse=reverse)
+                           reverse=reverse, string_table=string_table)
         create_flamegraphs(prom, group_by, ["cycle_tracker_span", "dsl_ir", "opcode", "air_name"], "cells_used",
-                           reverse=reverse)
+                           reverse=reverse, string_table=string_table)
         create_flamegraphs(prom, group_by, ["cell_tracker_span"], "cells_used",
                            sum_metrics=["simple_advice_cells", "fixed_cells", "lookup_advice_cells"],
-                           reverse=reverse)
+                           reverse=reverse, string_table=string_table)
 
 
 def main():
@@ -117,11 +126,18 @@ def main():
 
     argparser = argparse.ArgumentParser()
     argparser.add_argument('prometheus_url', type=str, help="Path to the prometheus server")
+    argparser.add_argument('--guest-symbols', type=str, help="Path to the guest symbols file", default=None, required=False)
     args = argparser.parse_args()
 
+    if args.guest_symbols:
+        with open(args.guest_symbols, 'rb') as f:
+            string_table = f.read()
+    else:
+        string_table = None
+
     prom = PrometheusConnect(url=args.prometheus_url, disable_ssl=True)
 
-    create_custom_flamegraphs(prom)
+    create_custom_flamegraphs(prom, string_table=string_table)
 
 
 if __name__ == '__main__':

crates/toolchain/transpiler/src/elf.rs

@@ -121,8 +121,6 @@ impl Elf {
 
                 for symbol in symtab.iter() {
                     if symbol.st_symtype() == elf::abi::STT_FUNC {
-                        let raw_name = stringtab.get(symbol.st_name as usize).unwrap().to_string();
-                        let demangled_name = rustc_demangle::demangle(&raw_name).to_string();
                         fn_bounds.insert(
                             symbol.st_value as u32,
                             FnBound {