Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate verifier-core into LCW #687

Open
jchartrand opened this issue Jan 31, 2025 · 0 comments
Open

integrate verifier-core into LCW #687

jchartrand opened this issue Jan 31, 2025 · 0 comments

Comments

@jchartrand
Copy link
Contributor

https://github.com/digitalcredentials/verifier-core is an extraction of the duplicate/common verification code that is in both VerifierPlus and LCW.

LCW (and VerifierPlus) therefore needs to be reworked to replace the existing verification code with verifier-core.

I've tried it at a high level in V+ and it does work - I replaced the call to verifyCredential in https://github.com/digitalcredentials/web-verifier-plus/blob/main/pages/api/verify.ts with the new call to verifier-core and it successfully returns the result.

See: digitalcredentials/web-verifier-plus#155

I've not yet tried it in LCW, but hopefully things more or less work. Note the undici caveat in the V+ issue above. Seems unlikely that will be a problem in LCW since it was seemingly a problem with the V+ NextJS SWC compiler.

The new result, however, is a bit different from the old result and so the code in LCW that uses the result has to be reworked to use the new result structure. The new result structure is a fair bit simpler though do this should help simplify the the LCW code too.

@alexfigtree alexfigtree moved this from Backlog to To Do (Current Sprint) in Learner Credential Wallet Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do (Current Sprint)
Development

No branches or pull requests

1 participant