min confirmation set to 1 requires 2 confirmations

[SimonVillage]

When setting min_confirmation to 1 the following condition will be true even if the transaction already has 1 confirmation.

app/workers/daemons/blockchain.rb:22

if bc.reload.height + bc.min_confirmations >= bc_service.latest_block_number
  logger.info { "Skip synchronization. No new blocks detected, height: #{bc.height}, latest_block: #{bc_service.latest_block_number}." }
  logger.info { 'Sleeping for 10 seconds' }
  sleep(10)
  next
end

bc.reload.height = 100
bc.min_confirmations = 1
bc_service.latest_block_number = 101

if 100 + 1 >= 101

will be true because of equal so processing will be skipped.

[SimonVillage]

@mnaichuk could you confirm this?

I wasn't sure if changing

if bc.reload.height + bc.min_confirmations >= bc_service.latest_block_number

would be enough in that case? I guess it's used more often?

[mnaichuk]

Hello @SimonHausdorf, yes you are right if we will put 1 confirmation or more it will raise an error if latest_block_number == height + min_confirmation. How do you want to change it?